Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error catching on URL loading is masking true errors #177

Closed
swainn opened this issue Feb 3, 2016 · 1 comment
Closed

Error catching on URL loading is masking true errors #177

swainn opened this issue Feb 3, 2016 · 1 comment
Assignees
Labels

Comments

@swainn
Copy link
Member

swainn commented Feb 3, 2016

The change of how urls are defined with function literals rather than strings in Django 1.9 means that the controllers are imported when Tethys loads all the urls from apps. There is some error catching that is being performed in the process that maps the Tethys app urls to Django urls that is meant to report more meaningful error messages for Tethys developers who aren't familiar with Django or the implementation of Tethys. Unfortunately, this error catching is somewhat ambiguous and is masking the true problems (usually import errors) that could be easily fixed if the original error and trace were reported. (See: https://groups.google.com/forum/#!topic/tethysplatform/7w6hFj2aG1c)

Solution: either remove this error catching so the default exceptions are raised or include the original text of the exception and the trace in the more Tethys appropriate exceptions.

See: https://github.com/tethysplatform/tethys/blob/master/tethys_apps/utilities.py#L56-L63

@swainn swainn added the bug label Feb 3, 2016
@sdc50 sdc50 self-assigned this Feb 25, 2016
@sdc50 sdc50 closed this as completed Feb 25, 2016
@sdc50
Copy link
Member

sdc50 commented Feb 25, 2016

I fixed this bug on the Aquaveo branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants