Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

GetCalloutAttributesFromContext return value does not contain body #95

Closed
doriandekoning opened this issue Nov 19, 2020 · 2 comments · Fixed by #96
Closed

GetCalloutAttributesFromContext return value does not contain body #95

doriandekoning opened this issue Nov 19, 2020 · 2 comments · Fixed by #96

Comments

@doriandekoning
Copy link
Contributor

doriandekoning commented Nov 19, 2020 •
edited
Loading

If I use GetCalloutAttributesFromContext on a callout with a body the body is not returned.

Is there a particular reason the body is not added here? If it can simply be added here I'd be happy to open a PR https://github.com/tetratelabs/proxy-wasm-go-sdk/blob/main/proxytest/root.go#L250
@mathetake
Copy link
Member

@doriandekoning Thanks for the report! This is not intentional so I would love to see your PR 😄 Thanks!

@doriandekoning doriandekoning mentioned this issue Nov 19, 2020
Merged
@doriandekoning
Copy link
Contributor Author

Here you go: #96

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add body to ProxyHttpCall return value weavedev/proxy-wasm-go-sdk
2 participants
@doriandekoning @mathetake