-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler: zero-initializes moduleInstanceAddress of call engine #783
Conversation
f8e55b1
to
98703be
Compare
will backfill more tests, but this should fix inkeliz/karmem#85 and aquasecurity/trivy#2791 @codefromthecrypt @inkeliz @knqyf263 |
ok verified that at least on my local machine, the PRs ^^ pass all tests. will do the backfilling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once the usage pattern that led to this in trivy and karmem is backfilled as a test!
@@ -558,50 +558,53 @@ func testCloseInFlight(t *testing.T, r wazero.Runtime) { | |||
|
|||
func testMemOps(t *testing.T, r wazero.Runtime) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this was exactly the same pattern in trivy and karmen - calling exported functions which might grow memory. But in order to catch this bug, I had to reuse the same api.Function, so I fixed it in that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and verified that without the patch, this test fails!
A bug in beta1 is fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io>
A bug in beta1 was fixed and released in beta2 tetratelabs/wazero#783 Signed-off-by: Adrian Cole <adrian@tetrate.io> Signed-off-by: Adrian Cole <adrian@tetrate.io>
This fixes a bug introduced in #761 where the reuse of the api.Function
causes some trouble around module context initialization.
Signed-off-by: Takeshi Yoneda takeshi@tetrate.io