-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: updates wazero to 1.0.0-pre.1 #2791
Conversation
|
Here are some notes about the prior integration test fail before I reverted TinyGo back to 0.24 cc @mathetake It was was out-of-memory in nature, but reported by wasm not the host function:
https://github.com/aquasecurity/trivy/runs/8087811856?check_suite_focus=true One thing a little confusing about it was that the module.go exports host memory, but that's not imported by the guest. // Instantiate a Go-defined module named "env" that exports functions.
_, err := r.NewModuleBuilder("env").
ExportMemory("mem", 100). but the guest defines its own memory: $ wasm2wat ./examples/module/spring4shell/spring4shell.wasm|less
--snip--
(memory (;0;) 3)
(global $__stack_pointer (mut i32) (i32.const 65536))
(export "memory" (memory 0)) If the error pops up again, maybe we need to look deeper, as for example the json size isn't reported in the error messages and no idea if that's larger than a page or not, or if it was should that matter. |
succeeded to reproduce this both on arm64 and amd64. will dig into this tomorrow. |
FYI |
@afdesk tinygo version was a red herring. We'll update this PR to wazero beta.2 when out soon. I originally thought 0.25 could have been behind the glitch, but it wasn't as it was our code. |
343cd04
to
be0d78c
Compare
ok now 1.0.0-beta.2 🤞 |
This updates [wazero](https://wazero.io) to 1.0.0-pre.1 A new pre-release will happen at least once each month until 1.0 in February 2023. Note: [Release notes](https://github.com/tetratelabs/wazero/releases) will be posted in the next day or two. Meanwhile, we've also opened a [gophers slack](https://gophers.slack.com/) `#wazero` channel for support, updates and conversation! Note: You may need an [invite](https://invite.slack.golangbridge.org/) to join gophers. Signed-off-by: Adrian Cole <adrian@tetrate.io>
be0d78c
to
d1b7700
Compare
changed to the new "pre" version convention which ensures no-one accidentally upgrades into the broken first beta. |
Thanks! |
This updates wazero to 1.0.0-pre.1
A new pre-release will happen at least once each month until 1.0 in February 2023.
Note: Release notes will be posted in the next day or two.
Meanwhile, we've also opened a gophers slack
#wazero
channel for support, updates and conversation! Note: You may need an invite to join gophers.