Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remark@9 #514

Merged
merged 4 commits into from
Mar 31, 2018
Merged

Update remark@9 #514

merged 4 commits into from
Mar 31, 2018

Conversation

Leko
Copy link
Member

@Leko Leko commented Mar 29, 2018

This PR fixed #513 but it has breaking changes about markdown parsing.

  1. entities-advanced.text match AST
  2. frontmatter-empty.text match AST
  3. frontmatter-extra-dashes.text match AST
  4. frontmatter-initial-lines.text match AST
  5. frontmatter-normal.text match AST
  6. frontmatter-only.text match AST
  7. links-inline-style.text match AST
  8. links-title-empty-parentheses.text match AST
  9. links-title-parentheses.text match AST
  10. links-url-new-line.text match AST
  11. links-url-white-space.text match AST
  12. title-attributes.text match AST

@Leko Leko self-assigned this Mar 29, 2018
@azu
Copy link
Member

azu commented Mar 30, 2018

You can update test fixtures by running node tools/update-fixtures.js

@Leko
Copy link
Member Author

Leko commented Mar 30, 2018

@azu Thank you for information.
I just thinking about that.

@Leko Leko changed the title [WIP] Update remark@9 Update remark@9 Mar 30, 2018
@azu azu self-requested a review March 30, 2018 14:28
@azu
Copy link
Member

azu commented Mar 30, 2018

Thanks for update.
it looks like that remark@^7...^9(remark-parse@5.0.0) is almost bug fix.

I think that most existing rules does not affected by this changes, but should we publish it as major release?
If we does major update, I want to consider about label:"Type: Breaking Change" like #443 #489

@Leko
Copy link
Member Author

Leko commented Mar 31, 2018

I think that most existing rules does not affected by this changes

Well, I think this PR released as not major release.

@Leko Leko merged commit 93ccc1b into textlint:master Mar 31, 2018
@Leko Leko deleted the update-remark branch March 31, 2018 15:38
@azu
Copy link
Member

azu commented Apr 2, 2018

@Leko OK. I'll release new version #516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

markdown-to-ast cannot parse query string correctly
2 participants