Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for detecting rio in textual diagnose #17

Closed
davep opened this issue Aug 31, 2023 · 4 comments
Closed

Add support for detecting rio in textual diagnose #17

davep opened this issue Aug 31, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@davep
Copy link
Contributor

davep commented Aug 31, 2023

It looks like rio doesn't currently advertise itself via TERM_PROGRAM or via any other obvious environment variable. The result is it comes out as *Unknown*.

It looks like XPC_SERVICE_NAME is always set (on macOS anyway) to something that starts with application.com.raphaelamorim.rio so this can work as a fallback detection method.

@davep davep added the enhancement New feature or request label Aug 31, 2023
@willmcgugan
Copy link
Contributor

Rio looks like one to watch. Maybe you could also post an issue on their repo asking for TERM_PROGRAM to be set?

@davep
Copy link
Contributor Author

davep commented Aug 31, 2023

@willmcgugan Yeah, I've discovered a few issues with it in my brief play this morning, so I was going to take some time this weekend, hopefully, to drive in and make notes and then issue some things (see also function keys seemingly not working, line characters not performing well, some characters not lining up well, screens not fully drawing often, etc...).

@davep
Copy link
Contributor Author

davep commented Aug 31, 2023

Raised this specific one as raphamorim/rio#200

@davep
Copy link
Contributor Author

davep commented Aug 31, 2023

No longer necessary as support for TERM_PROGRAM has now been added to rio.

@davep davep closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants