Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oven reward payout failed / not authorized depositor #106

Closed
dansan566 opened this issue Dec 5, 2021 · 4 comments · Fixed by #110 or #112
Closed

Oven reward payout failed / not authorized depositor #106

dansan566 opened this issue Dec 5, 2021 · 4 comments · Fixed by #110 or #112

Comments

@dansan566
Copy link

dansan566 commented Dec 5, 2021

Hey everyone,
we experienced an issue when sending rewards to ctez oven delegators. Most of the bakers do not send out the rewards from their baking address. It's common to send those via a payout address!

Hotfix for TRD user:
We can redirect payments to the specific owners. However, this is not a scalable solution.

Suggestion:
Please add the specific baker payout address within "authorized depositors" as well!

Is there a reason to limit depositors anyway? So why wouldn't you want to allow anybody else to add more collateral on your behalf by default? I'm curious to hear.

@jdsika
Copy link

jdsika commented Dec 16, 2021

Any updates on this one?

@nicolasochem
Copy link

The checker documentation states Fails if the burrow does not exist, if the sender does not own said collateral, . There is no rationale provided for this.

It may be better to open a ticket in the original ctez repo?

@berndoostrum
Copy link

berndoostrum commented Dec 18, 2021

I think making "everyone" selected by default could help. image

For users that need the whitelist functionality we can add a warning, or if the data of payout addresses is available somewhere we could import it automatically. image

There can be legal reasons to limit depositors. Not sure about the exact specifications though.

@baketzforme
Copy link

baketzforme commented Dec 18, 2021

When I created my oven, at first I selected Everyone because I thought, "Why wouldn't I want everyone/anyone to be able to deposit funds on my behalf?"

Then I saw this tooltip:

Authorized Depositors

That makes it sound like if you allow everyone/anyone, they can also mint the ctez from your oven and cause it to be liquidated. So I changed from Everyone to using a whitelist because of that tooltip. Basically, it scared me into making the wrong decision.

I think a good solution is to fix that tooltip and make Everyone the default.

@berndoostrum berndoostrum linked a pull request Dec 24, 2021 that will close this issue
berndoostrum added a commit that referenced this issue Dec 24, 2021
@berndoostrum berndoostrum linked a pull request Dec 24, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants