Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give feedback during slow function calls #82

Closed
tfiers opened this issue Jan 16, 2023 · 7 comments
Closed

Give feedback during slow function calls #82

tfiers opened this issue Jan 16, 2023 · 7 comments
Labels
feature An enhancement to src/ visible to end-users
Milestone

Comments

@tfiers
Copy link
Owner

tfiers commented Jan 16, 2023

Try e.g. in a fresh session, using PkgGraph; depgraph_image(:Plots). is slow.

so ig, figure out uncompiled methods. some kinda flag, or a julia internal we can abuse

@tfiers tfiers added the feature An enhancement to src/ visible to end-users label Jan 16, 2023
@tfiers tfiers added this to the v1 milestone Jan 16, 2023
@tfiers
Copy link
Owner Author

tfiers commented Jan 16, 2023

Actually subsequent runs are also kinda slow, for this big (and non-installed) package (compare with eg :ChainRulesCore).

so yes, some kinda progress indication here. as predicted in

mayb if gathering deps (repeatedly calling that init_pkg_info!) is slow, then a line for each or sth

@tfiers tfiers changed the title Give feedback during slow first run Give feedback during slow first run (#TTFX) Jan 28, 2023
@tfiers
Copy link
Owner Author

tfiers commented Jan 28, 2023

Ooh actually, SnoopPre :)

@tfiers
Copy link
Owner Author

tfiers commented Jan 28, 2023

Re

hah, so it wasn't a precomp issue
image

so it's more like "Give feedback during slow function calls"

@tfiers tfiers changed the title Give feedback during slow first run (#TTFX) Give feedback during slow function calls Jan 28, 2023
@tfiers
Copy link
Owner Author

tfiers commented Jan 28, 2023

step 1:

  • profile

oh god, profview on WSL..

ok, according to this [https://learn.microsoft.com/en-us/windows/wsl/tutorials/gui-apps], should be possible
so, downloading 1GB "Intel® Graphics – Windows* DCH Drivers", gfx_win_101.3790_101.2114.exe

oh wow, gedit example works out of the box, not even having installed that intel gpu driver

ok and profview works out of the box too.
so I'm scared of that driver: could make it not work anymore

To run Linux GUI apps, you should first install the driver matching your system below. This will enable you to use a virtual GPU (vGPU) so you can benefit from hardware accelerated OpenGL rendering.

Do I have vGPU / hardware-accelerated OpenGL rendering already?

https://www.hanselman.com/blog/how-to-run-linux-gui-apps-on-windows-10-with-wsl-and-wslg
https://ubuntu.com/tutorials/enabling-gpu-acceleration-on-ubuntu-on-wsl2-with-the-nvidia-cuda-platform#1-overview

ok, two trusted sources, seems legit

someone w/ same question: microsoft/wslg#78
glxinfo is part of that Mesa
https://en.wikipedia.org/wiki/Mesa_(computer_graphics)

an open source implementation of OpenGL, Vulkan, and other graphics API specifications. Mesa translates these specifications to vendor-specific graphics hardware drivers

The intel installer failed (I chose "clean install (remove old drivers & reset settings to default)"; but it said sth "file not found" halfwya tru)

@tfiers
Copy link
Owner Author

tfiers commented Jan 28, 2023

image

image

ok, so can't optimize that really.
So, feedback there, sure :)

only in direct_deps_from_registry (double clicked it; opened in code. woah. <3 ProfileView)

@tfiers
Copy link
Owner Author

tfiers commented Jan 28, 2023

We don't know how deep the rabbit hole goes (how many pkgs in tree) beforehand.
So, cannot use the nice ProgressMeter.jl

I want the cool spinners of Pkg etc

oh no, ProgressMeter has them: https://github.com/timholy/ProgressMeter.jl#progress-meters-for-tasks-with-an-unknown-number-of-steps

@tfiers
Copy link
Owner Author

tfiers commented Jan 28, 2023

So ok, we have this now (see upcoming commit closing this).
though there is about 4 secs delay before it shows up:

..and ProgressMeter.jl has no precompilation, alas.

@tfiers tfiers closed this as completed in cff150c Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature An enhancement to src/ visible to end-users
Projects
None yet
Development

No branches or pull requests

1 participant