Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle media types application/yaml and application/json #42

Closed
wants to merge 2 commits into from

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Apr 27, 2020

Fixes #41

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #42 into master will decrease coverage by 0.16%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   95.21%   95.04%   -0.17%     
==========================================
  Files          36       36              
  Lines        1942     1957      +15     
==========================================
+ Hits         1849     1860      +11     
- Misses         93       97       +4     
Impacted Files Coverage Δ
drf_spectacular/renderers.py 82.60% <75.00%> (-17.40%) ⬇️
drf_spectacular/views.py 96.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69fb791...9dee6c4. Read the comment docs.

@jayvdb
Copy link
Contributor Author

jayvdb commented Apr 27, 2020

I am not real sure about the best way to do the second commit adding two classes for the two extra mime types. I expect there should be a better way.

tfranzel added a commit that referenced this pull request Apr 27, 2020
@jayvdb
Copy link
Contributor Author

jayvdb commented Apr 28, 2020

So 266904c1d0 is using the exact same approach as my commit in this PR; a bit neater of course.

@tfranzel
Copy link
Owner

tfranzel commented May 3, 2020

superseded by 5f4fa7d and 266904c

@tfranzel tfranzel closed this May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure on SpectacularAPIView when unexpected mime type provided
2 participants