Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate direct support for git-bash in Windows #144

Closed
Zordrak opened this issue Oct 29, 2019 · 3 comments
Closed

Investigate direct support for git-bash in Windows #144

Zordrak opened this issue Oct 29, 2019 · 3 comments

Comments

@Zordrak
Copy link
Collaborator

Zordrak commented Oct 29, 2019

See #140

@Zordrak
Copy link
Collaborator Author

Zordrak commented Oct 29, 2019

@stephengroat at first glance, the failure is symlink related.

My recent experience with git-bash is that symlinking cannot be trusted even when support is explicitly installed.

Needs some deeper investigation to see if it can be made to function reliably.

@sworisbreathing
Copy link

I haven't looked at the travis result but I just installed it in git bash on windows and so far it seems to work. There's an issue with tf-install because git bash struggles with the type of stdin redirection used in the read loop. Since that loop is only logging outputs it doesn't seem to break anything as far as actual functionality

@stephengroat
Copy link
Contributor

stephengroat commented Mar 24, 2020

@Zordrak after merging master, all tests pass now for windows

see #140

@Zordrak Zordrak closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants