Mysql2 should also listen to 'error' events. #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
I've debugged this further and it is in fact the case. Connections aren't being disposed using the "MySQL Specific handler" when specified driver is mysql2. This fixes that problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly noticed in #1198 there's a diff between how
mysqlandmysql2handle events, yet they're both almost identical. I can't find anendevent inmysql2, but theerroris there (with the appropiate "fatal" flag) so unless I'm missing something it should be listened to here as well.https://github.com/sidorares/node-mysql2/blob/master/lib/connection.js#L96
@elhigu @rhys-vdw Does this make sense to you?