Allow joins to nest conditional statements

[atiertant]

fix #690

make this possible:

.leftOuterJoin('accounts', function () {
    this
      .on('users.id', 'account.user_id')
      .andOn(function () {
         this.on('users.state', '=', 'NULL');
         this.orOn('users.state', 'accounts.state');
      });
  });

[rhys-vdw]

@atiertant Awesome work. Just requires test and documentation and we can get this in a release.

[atiertant]

@rhys-vdw where could i add documentation ? didn't see this in CONTRIBUTING.md ...

[rhys-vdw]

Yeah, sorry, we need a pull request template. PRs need tests and docs. The
documentation is just index.html (which is the website).

On Thu, May 12, 2016, 5:20 PM Alexandre Tiertant notifications@github.com
wrote:

@rhys-vdw https://github.com/rhys-vdw where could i add documentation ?
didn't see this in CONTRIBUTING.md ...

—
You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#1397 (comment)

[atiertant]

@rhys-vdw hope all is correct

[rhys-vdw]

@atiertant Thanks for following that up. Looks great. 👍

[rhys-vdw]

Just released this as knex 0.11.3

[villelahdenvuo]

Buh, I was just trying achieve this and I read the docs and I was like why isn't this working even though the docs say it should, but once I found these issues I realized it's a brand new feature.

[helios1138]

@rhys-vdw knex 0.11.9 - not working

[atiertant]

@helios1138 have you got a failling code?

[emaddoma]

My own attempt to use this failed.

q.innerJoin('account_meta_catalog', function() {
    this.on('account_meta_catalog.account_id','=','accounts.id');
    this.andOn(function(){
        this.on(knex.raw("(account_meta_catalog.catalog->'card'->>'has_medical_discount_plan')::boolean = true"));
        this.orOn(knex.raw("(account_meta_catalog.catalog->'card'->>'has_dental_discount_plan')::boolean = true"));
    });
});

Results in error "TypeError: listener must be a function"