Allow using custom Client/Dialect #1428
Conversation
- Test for implemented case - Test for currently untested case
|
Hmm... test fails for some unknown reason. All ok on my own branch https://travis-ci.org/vellotis/knex/builds/131377631. The same commit 41344a9. |
| @@ -25,6 +25,8 @@ export default function Knex(config) { | |||
| let Dialect; | |||
| if (arguments.length === 0 || (!config.client && !config.dialect)) { | |||
| Dialect = makeClient(Client) | |||
| } else if (typeof config.client === 'function' && config.client.prototype instanceof Client) { | |||
There was a problem hiding this comment.
This can be simplified to:
} else if (config.client instanceof Client) {instanceof will walk the prototype list. It will return false if config.client is not a function.
There was a problem hiding this comment.
@rhys-vdw I must say that you are not right. You are not passing initialized Client but the definition of the Client. Lets see it in node cli.
> Client = require('knex').Client
{ [Function: Client] ... }
> MysqlClient = require('knex/lib/dialects/mysql')
{ [Function: Client_MySQL] ... }
> MysqlClient instanceof Client
false
> MysqlClient.prototype instanceof Client
true
Don't sweat it. Sometimes the tests time out. I can just re-run that individual test (you can see most node versions passed). If you push a commit addressing my line note the tests will re-run anyway. |
|
BR 🎉 |
|
👍 |
|
I think this would really need documentations since it is new feature... I'll open issue for it. |
|
FYI i made use of custom dialect feature. The only problem i see is a wierd way of getting ancestors: |
Solve #1424
To oppose @rhys-vdw note in #1424.
I stand to my suggested solution. Client API is really much knex version dependent. If some version of knex would change the API, the plugin-client would stop working any way. So there is no point supporting any other soft verification.
Two tests added.
As well PR #1427 merging with this PR would be welcomed.