Insert causes error when no id field defined.

[vjpr]

{ sql: 'insert into "users" ("first_name") values ($1) returning "id"',
  bindings: [ 'xxx' ],
  __cid: '__cid2' }

timers.js:103
            if (!process.listeners('uncaughtException').length) throw e;
                                                                      ^
error: column "id" does not exist

[tgriesser]

For the time being, the fix for this is to add .idAttribute(null) on the builder chain... though I'm looking to change this to be .insert(values, [returning])... where if you specified the returning column you'd get back that from the insert (only required for postgres). Does that seem like it'd be a logical api?

[vjpr]

Yeh looks good.

I'd just mention that the sequelize library uses the 2nd parameter of its create method to pass in an array of settable attributes. The benefit is that it saves the user having to write checks for what attributes the user (of say a web app) is allowed to change. However, this is probably more Bookshelf.js territory.

[tgriesser]

Yeah, that'd fall more under Bookshelf... I had added whitelist/blacklist attributes in there for mass assignment, but then I decided to remove them and leave that up to the user to implement.

It's really easy to add the kitchen sink when it comes to validations/assignment and they can get pretty complex, so I'm going to try to keep it bare bones for now and focus mostly on doing a good job with relations (just added polymorphic associations btw).

I'll try to get to this returning issue a little later today.

[neilk]

Just got bitten with this one too. In my case my table doesn't even have a single 'id' field (there's a compound key). The assumption of an 'id' field seems to be pervasive in Knex/Bookshelf, but maybe that's okay.

I like your idea of a "returning" option - my expectation would be that it would be off by default.