Remove Bluebird.try #3263
Merged
Remove Bluebird.try #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please check eslint, it fails on every environment. |
added 2 commits
June 7, 2019 07:26
|
|
If you have docker installed, running tests is pretty straightforward also locally. |
|
Yea i let oracle docker install overnight, but it seemed to fail, so I'm just running I'm currently trying to figure out the best way to get around the |
You could just start all other databases except oracle and run tests with something like:
Yea... that sounds like a quite non trivial to do and pretty crucial when making sure that pooling stuff is not leaked. I haven't really though about how to solve that in a robust manner. |
|
Ok so that one FYI everything passes locally except for the 2 tests that were failing on master for me as well... don't know if that seems to be an issue |
kibertoad
reviewed
Jun 7, 2019
scripts/build.js
Outdated
| return exec('npm install ' + installArgs, opts); | ||
| } | ||
| }) | ||
| var needsDepInstallation = !_.isEmpty(installArgs); |
There was a problem hiding this comment.
do these need to be var? can they be const?
There was a problem hiding this comment.
Done! Was not sure what files are transpiled and which ones weren't, so I adhered to whatever the current file used (const if it had const or let, otherwise var)
There was a problem hiding this comment.
I believe nothing is transpiled anymore, both babel and support for node 6 were dropped.
kibertoad
reviewed
Jun 7, 2019
kibertoad
reviewed
Jun 7, 2019
|
Ok just to continue the thoughts from the start of the thread, I think it makes sense to keep this PR just targetting the I think what i'd like to propose in a separate PR is some way to implement the Thoughts? |
|
@chaffeqa Makes sense! Let's do this as incrementally as possible. |
kibertoad
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still waiting on oracle docker 🙄 but think this is ok...
Should resolve #3253