Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silo calc fix #15563

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Silo calc fix #15563

merged 1 commit into from
Apr 7, 2024

Conversation

Lumipharon
Copy link
Contributor

@Lumipharon Lumipharon commented Apr 4, 2024

About The Pull Request

Hotfix: Stops the larva gen calc including minions.

So minions are counted as xenos for the glob list purposes. This issue actually effects other stuff (like autobalance) not just larva gen, so a proper fix is needed, but pr'ing this now so benos don't get owned by having loads of minions.

Why It's Good For The Game

Minion spam nerfing the hive is funny but notgud

Changelog

🆑
fix: Larva gen no longer counts minions when calculating xeno pop
/:cl:

@tgstation-server tgstation-server added the Fix Fixes an issue with the game. label Apr 4, 2024
@Kuro020 Kuro020 added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Apr 4, 2024
comfyorange added a commit that referenced this pull request Apr 4, 2024
comfyorange added a commit that referenced this pull request Apr 6, 2024
@BraveMole BraveMole merged commit 3c64b49 into tgstation:master Apr 7, 2024
7 checks passed
github-actions bot added a commit that referenced this pull request Apr 7, 2024
@Lumipharon Lumipharon deleted the silo_calc_fix branch April 9, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fixes an issue with the game. Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants