Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valhalla xenos are of the xeno faction #15652

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

ivanmixo
Copy link
Contributor

@ivanmixo ivanmixo commented Apr 13, 2024

About The Pull Request

Yes.

Why It's Good For The Game

This messes fixes directional attacks not working on the dummies you spawn in.

Changelog

🆑
fix: Valhalla xenos can use directional attacks on the puppets they spawn now
/:cl:

@tgstation-server tgstation-server added the Fix Fixes an issue with the game. label Apr 13, 2024
@Lumipharon
Copy link
Contributor

This doesn't curse other stuff does it? Weren't valhalla stuff their own faction for a reason?

@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Apr 14, 2024
@ivanmixo
Copy link
Contributor Author

This was completely unintended, so no. I don't think anything uses the faction string for calculations and if it does that should be rectified

comfyorange added a commit that referenced this pull request Apr 15, 2024
comfyorange added a commit that referenced this pull request Apr 17, 2024
comfyorange added a commit that referenced this pull request Apr 17, 2024
@Lumipharon Lumipharon merged commit 22cb49b into tgstation:master Apr 18, 2024
34 checks passed
github-actions bot added a commit that referenced this pull request Apr 18, 2024
@ivanmixo ivanmixo deleted the dir-xallhalla branch October 4, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fixes an issue with the game. Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants