Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the CPC (Clone Personnel Carrier) module #15783

Merged
merged 11 commits into from
May 25, 2024

Conversation

Lumipharon
Copy link
Contributor

@Lumipharon Lumipharon commented May 2, 2024

About The Pull Request

Adds the PERFECTLY BALANCED, WELL THOUGHT OUT cloner module to the APC.
image

You chug around, pumping out cheap clone troopers who can gear up with the noob vendor (or extra gear if you load it in).
Not pictured is the APC gibber, which produces additional biomass, so you can recycle bodies for YET MORE clone soldiers.

Why It's Good For The Game

Marine spawner.
Balance perfection.

Changelog

🆑
add: Added a cloner module for the APC
/:cl:

@tgstation-server tgstation-server added Sprites Changes to .dmi file. Map Edit One or more changes to .dmm files. Feature New interesting mechanics with new interesting bugs labels May 2, 2024
@Tonklaatech
Copy link

The weapon to surpass Metal Gear.

@FosterGrime-Heymynameslouie
Copy link
Contributor

spedemrhg instantly

@74delta
Copy link
Contributor

74delta commented May 2, 2024

Holy fuck please

@SimplySmiley123
Copy link

So real.

@iforgotmeword
Copy link

iforgotmeword commented May 2, 2024

IMG_0967

same energy
(Wait holy fuck doesn’t that mean marines now have a banding with clone with bomb vests?

Speedmerge NOW

@ilikesaying
Copy link

robot version when

@Admiral-Gigaton
Copy link

Admiral-Gigaton commented May 2, 2024

can you, if its not already implemented in this PR, make it so corpses can be loaded into the gibber from the outside, and/or gib xeno corpses for biomass (no one sends up minion corpses, so it would work out)

its confusing and hard to load corpses n crates into an APC, and not many people know how to, so this would help. or you could make the info about loading things in more available to people.

otherwise, love this PR, hope it doesnt get shot down, and are there any other cons to doing this, besides getting shitty gear?

also, does this pull from ghost pool, or is it a DNA scanner moment. could i die, and become fully round removed, but my gear dropped onto the APC, where i then clone via ghost spawn, and pick up my shit?

QUESTIONS!!

@Wisemonster
Copy link
Contributor

can you, if its not already implemented in this PR, make it so corpses can be loaded into the gibber from the outside, and/or gib xeno corpses for biomass (no one sends up minion corpses, so it would work out)

its confusing and hard to load corpses n crates into an APC, and not many people know how to, so this would help. or you could make the info about loading things in more available to people.

otherwise, love this PR, hope it doesnt get shot down, and are there any other cons to doing this, besides getting shitty gear?

also, does this pull from ghost pool, or is it a DNA scanner moment. could i die, and become fully round removed, but my gear dropped onto the APC, where i then clone via ghost spawn, and pick up my shit?

QUESTIONS!!

To answer some of these, I'm pretty sure these are just the medbay cloners stuck into an apc, so they will work how the medbay cloner currently works

@Admiral-Gigaton
Copy link

can you, if its not already implemented in this PR, make it so corpses can be loaded into the gibber from the outside, and/or gib xeno corpses for biomass (no one sends up minion corpses, so it would work out)
its confusing and hard to load corpses n crates into an APC, and not many people know how to, so this would help. or you could make the info about loading things in more available to people.
otherwise, love this PR, hope it doesnt get shot down, and are there any other cons to doing this, besides getting shitty gear?
also, does this pull from ghost pool, or is it a DNA scanner moment. could i die, and become fully round removed, but my gear dropped onto the APC, where i then clone via ghost spawn, and pick up my shit?
QUESTIONS!!

To answer some of these, I'm pretty sure these are just the medbay cloners stuck into an apc, so they will work how the medbay cloner currently works

I have no idea how the medbay cloner works, i havent been cloned before (besides 1 case but i barely remember)

@bowlofcereal
Copy link
Contributor

this better start with a lot of biomass considering it takes like one whole beaker of biomass for one clone and there are 8 of these, so 8 biomass beakers each time it creates one

i've got a feeling this is going to be a module pick that makes people scream "griefer" because of this

@lbnesquik
Copy link
Contributor

this better start with a lot of biomass considering it takes like one whole beaker of biomass for one clone and there are 8 of these, so 8 biomass beakers each time it creates one

i've got a feeling this is going to be a module pick that makes people scream "griefer" because of this

Bowl is right, biomass is expensive to run.

@Lumipharon
Copy link
Contributor Author

they don't know

@00ze-cyclone
Copy link
Contributor

this better start with a lot of biomass considering it takes like one whole beaker of biomass for one clone and there are 8 of these, so 8 biomass beakers each time it creates one
i've got a feeling this is going to be a module pick that makes people scream "griefer" because of this

Bowl is right, biomass is expensive to run.

Biomass is expensive sure but you can get more biomass, you can’t get more cloners, those are the true bottleneck of the clone army, then it’s just a matter of fundings

@lbnesquik
Copy link
Contributor

They did mention a gibber for biomass. It's just, you can't drag xeno bodies inside the APC, can you?

@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label May 4, 2024
@github-actions github-actions bot added the Merge Conflict Pull request is in a conflicted state with base branch. label May 4, 2024
Comment on lines 70 to +71
// Try to find the machine nearby
linked_machine = locate() in orange(1, src)
linked_machine = locate() in get_step(src, REVERSE_DIR(dir))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like we should check this in init as well and have a log_mapping fail

@tgstation-server tgstation-server removed Merge Conflict Pull request is in a conflicted state with base branch. Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. labels May 4, 2024
@Lumipharon Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label May 4, 2024
@yyzsong
Copy link
Contributor

yyzsong commented May 4, 2024

this better start with a lot of biomass considering it takes like one whole beaker of biomass for one clone and there are 8 of these, so 8 biomass beakers each time it creates one

i've got a feeling this is going to be a module pick that makes people scream "griefer" because of this

you get like two and a half clones per beaker you'll be fine

comfyorange added a commit that referenced this pull request May 4, 2024
@Lumipharon
Copy link
Contributor Author

fix the clone turbo spam issue pls, this module outclasses the other two by far

What do you want me to change? I made it because it was funny, not with serious balance in mind, but I'm open to change whatever. Less cloners? Longer clone time? less biomass per body?

iirc main issue is that people scrape up the prespawn bodies to get endless clones

Changed so mapspawn bodies can no longer be gibbed for biomass.
Changed the base biomass per meat from 5 to 1, so a lot less biomass over all.

Also fixed some vehicle runtimes while I was at it.

@Lumipharon Lumipharon requested a review from TiviPlus May 15, 2024 10:31
comfyorange added a commit that referenced this pull request May 15, 2024
@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label May 15, 2024
comfyorange added a commit that referenced this pull request May 15, 2024
comfyorange added a commit that referenced this pull request May 15, 2024
comfyorange added a commit that referenced this pull request May 15, 2024
comfyorange added a commit that referenced this pull request May 16, 2024
@ivanmixo
Copy link
Contributor

Don't think adding marine baneling is a good idea, even if it is funny

comfyorange added a commit that referenced this pull request May 16, 2024
comfyorange added a commit that referenced this pull request May 16, 2024
comfyorange added a commit that referenced this pull request May 17, 2024
comfyorange added a commit that referenced this pull request May 17, 2024
comfyorange added a commit that referenced this pull request May 18, 2024
comfyorange added a commit that referenced this pull request May 19, 2024
comfyorange added a commit that referenced this pull request May 20, 2024
comfyorange added a commit that referenced this pull request May 21, 2024
@chizzy376
Copy link
Contributor

Changed so mapspawn bodies can no longer be gibbed for biomass

Good change! But I'd like to know,

Changed the base biomass per meat from 5 to 1, so a lot less biomass over all.

Does this mean that instead of needing to gib 2 DNR marines, you need to gib 10 to make enough biomass?

comfyorange added a commit that referenced this pull request May 21, 2024
comfyorange added a commit that referenced this pull request May 22, 2024
comfyorange added a commit that referenced this pull request May 23, 2024
comfyorange added a commit that referenced this pull request May 23, 2024
comfyorange added a commit that referenced this pull request May 23, 2024
@TiviPlus
Copy link
Member

Looks to be okish now?

@TiviPlus TiviPlus merged commit 1c41725 into tgstation:master May 25, 2024
34 checks passed
github-actions bot added a commit that referenced this pull request May 25, 2024
@Lumipharon Lumipharon deleted the clone_p_c branch May 25, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New interesting mechanics with new interesting bugs Map Edit One or more changes to .dmm files. Sprites Changes to .dmi file. Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.