Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Okay a whole lot of things lack proper sanity checks for alt-clicking #81242

Closed
MrMelbert opened this issue Feb 2, 2024 · 2 comments · Fixed by #82656
Closed

Okay a whole lot of things lack proper sanity checks for alt-clicking #81242

MrMelbert opened this issue Feb 2, 2024 · 2 comments · Fixed by #82656
Labels
Oversight We have no quality control

Comments

@MrMelbert
Copy link
Contributor

Issue Summary

  • Tape recorder (partially)
  • Autolathe
  • Pillow
  • Ethereal Disco Ball
  • Health Assembly
  • Medical roller bed
  • Toilet Bong
  • Cigarette boxes
  • Wrapping Paper
  • Medical Mesh (partially0
  • Cyborg organ storage
  • Cyborg apparatuses in general
  • Borg Hypospray
  • Rapid Wiring Device
  • Plumbing Device
  • Electrolyzer (partially)
  • Thermomachine (partially)
  • Universal Scanner
  • Glasses / Debug glasses
  • Inspector Gadget fedora
  • Animal mask
  • Bandanas (partially)
  • Neck ties
  • Uniforms (partially)
  • Hotel door (partially)
  • Goliath Cloak (partially)
  • Clipboard
  • Papercutter (partially)
  • Bow (partially)
  • Chem mass spectrometer (partially)
  • Chem reaction tester (though this is debug, so it doesn't really matter)
  • Portable chem mixer (partially)
  • Mortar (partially)
  • Syrup bottle
  • Coffee cup
  • Water bottle
  • Sales Tagger
  • Destructive Analyzer
  • Tram remote assemblies
  • Tram crossing signals
@MrMelbert MrMelbert added the Oversight We have no quality control label Feb 2, 2024
This was referenced Feb 2, 2024
Closed
Closed
Closed
@SyncIt21 SyncIt21 mentioned this issue Feb 2, 2024
Merged
@lessthnthree lessthnthree mentioned this issue Feb 2, 2024
Merged
@DATA-xPUNGED
Copy link
Contributor

What do you mean by sanity check, by the way? Just curious

@MrMelbert
Copy link
Contributor Author

MrMelbert commented Feb 3, 2024 •
edited

What do you mean by sanity check, by the way? Just curious

  • Check that the mob is in range
  • Check that the mob is a valid mob (Humans, generally)
  • Check that the mob is not dead, or otherwise incapacitated (handcuffed, stunned, or in crit)
  • Check any other relevant details for the interaction (Dexterity / advanced tool user, telekinesis, is the machine powered, etc)

Kylerace pushed a commit that referenced this issue Feb 3, 2024
@lessthnthree
Fixes tram alt-click interactions (#81255)
d8729bb 
## About The Pull Request

A part of #81242

## Why It's Good For The Game

Don't interact with things you shouldn't be

## Changelog

:cl: LT3
fix: Fixed alt-click validation for tram interactions
/:cl:
NovaBot13 pushed a commit to NovaSector/NovaSector that referenced this issue Feb 3, 2024
@lessthnthree @NovaBot13
Fixes tram alt-click interactions (#81255)
97f87e6 
## About The Pull Request

A part of tgstation/tgstation#81242

## Why It's Good For The Game

Don't interact with things you shouldn't be

## Changelog

:cl: LT3
fix: Fixed alt-click validation for tram interactions
/:cl:
@NovaBot13 NovaBot13 mentioned this issue Feb 3, 2024
Merged
SkyratBot pushed a commit to Skyrat-SS13/Skyrat-tg that referenced this issue Feb 3, 2024
@lessthnthree @SkyratBot
Fixes tram alt-click interactions (#81255)
247154e 
## About The Pull Request

A part of tgstation/tgstation#81242

## Why It's Good For The Game

Don't interact with things you shouldn't be

## Changelog

:cl: LT3
fix: Fixed alt-click validation for tram interactions
/:cl:
@SkyratBot SkyratBot mentioned this issue Feb 3, 2024
Merged
NaakaKo pushed a commit to Bird-Lounge/Skyraptor-SS13 that referenced this issue Feb 3, 2024
@lessthnthree @NaakaKo
Fixes tram alt-click interactions (#81255)
e60fc20 
## About The Pull Request

A part of tgstation/tgstation#81242

## Why It's Good For The Game

Don't interact with things you shouldn't be

## Changelog

:cl: LT3
fix: Fixed alt-click validation for tram interactions
/:cl:
@NaakaKo NaakaKo mentioned this issue Feb 3, 2024
Merged
TaleStationBot pushed a commit to TaleStation/TaleStation that referenced this issue Feb 3, 2024
@lessthnthree @TaleStationBot
Fixes tram alt-click interactions (#81255)
bebcd49 
## About The Pull Request

A part of tgstation/tgstation#81242

## Why It's Good For The Game

Don't interact with things you shouldn't be

## Changelog

:cl: LT3
fix: Fixed alt-click validation for tram interactions
/:cl:
@TaleStationBot TaleStationBot mentioned this issue Feb 3, 2024
Merged
SomeRandomOwl pushed a commit to NovaSector/NovaSector that referenced this issue Feb 3, 2024
@NovaBot13 @lessthnthree
[MIRROR] Fixes tram alt-click interactions (#754)
c87316a 
* Fixes tram alt-click interactions (#81255)

## About The Pull Request

A part of tgstation/tgstation#81242

## Why It's Good For The Game

Don't interact with things you shouldn't be

## Changelog

:cl: LT3
fix: Fixed alt-click validation for tram interactions
/:cl:

* Fixes tram alt-click interactions

---------

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
Iajret pushed a commit to Fluffy-Frontier/FluffySTG that referenced this issue Feb 3, 2024
@NovaBot13 @lessthnthree
[MIRROR] Fixes tram alt-click interactions (#754)
8cf2fdb 
* Fixes tram alt-click interactions (#81255)

## About The Pull Request

A part of tgstation/tgstation#81242

## Why It's Good For The Game

Don't interact with things you shouldn't be

## Changelog

:cl: LT3
fix: Fixed alt-click validation for tram interactions
/:cl:

* Fixes tram alt-click interactions

---------

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
@Steals-The-PRs Steals-The-PRs mentioned this issue Feb 3, 2024
Merged
Jolly-66 pushed a commit to TaleStation/TaleStation that referenced this issue Feb 3, 2024
@TaleStationBot @lessthnthree
[MIRROR] [MDB IGNORE] Fixes tram alt-click interactions (#9624)
40c4fbf 
Original PR: tgstation/tgstation#81255
-----
## About The Pull Request

A part of tgstation/tgstation#81242

## Why It's Good For The Game

Don't interact with things you shouldn't be

## Changelog

:cl: LT3
fix: Fixed alt-click validation for tram interactions
/:cl:

---------

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
jjpark-kb pushed a commit to Skyrat-SS13/Skyrat-tg that referenced this issue Feb 4, 2024
@SkyratBot @lessthnthree
[MIRROR] Fixes tram alt-click interactions (#26340)
77c474f 
* Fixes tram alt-click interactions (#81255)

## About The Pull Request

A part of tgstation/tgstation#81242

## Why It's Good For The Game

Don't interact with things you shouldn't be

## Changelog

:cl: LT3
fix: Fixed alt-click validation for tram interactions
/:cl:

* Fixes tram alt-click interactions

---------

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
FernandoJ8 pushed a commit to FernandoJ8/tgstation that referenced this issue Feb 4, 2024
@lessthnthree @FernandoJ8
Fixes tram alt-click interactions (tgstation#81255)
97983e4 
A part of tgstation#81242

Don't interact with things you shouldn't be

:cl: LT3
fix: Fixed alt-click validation for tram interactions
/:cl:
lessthnthree added a commit to effigy-se/effigy-se that referenced this issue Feb 8, 2024
@lessthnthree
Fixes tram alt-click interactions (#81255)
4326320 
## About The Pull Request

A part of tgstation/tgstation#81242

## Why It's Good For The Game

Don't interact with things you shouldn't be

## Changelog

:cl: LT3
fix: Fixed alt-click validation for tram interactions
/:cl:
@jlsnow301 jlsnow301 mentioned this issue Apr 14, 2024
Merged
san7890 pushed a commit that referenced this issue Apr 16, 2024
@jlsnow301
Alt click refactor (#82656)
8e3f635 
## About The Pull Request
Rewrites how alt click works. 
Based heavily on #82625. What a cool concept, it flows nicely with
#82533.

Fixes #81242 
(tm bugs fixed)
Fixes #82668

<details><summary>More info for devs</summary>

Handy regex used for alt click s&r:
`AltClick\((.*).*\)(\n\t.*\.\.\(\))?`
`click_alt($1)` (yes I am aware this only copies the first arg. there
are no other args!)

### Obj reskins
No reason for obj reskin to check on every single alt click for every
object. It applies to only a few items.
- Moved to obj/item
- Made into signal
- Added screentips

### Ventcrawling
Every single atmospherics machine checked for ventcrawling capability on
alt click despite only 3 objects needing that functionality. This has
been moved down to those individual items.
</details>

## Why It's Good For The Game
For players: 
- Alt clicking should work more logically, not causing double actions
like eject disk and open item window
- Added context menus for reskinnable items
- Removed adjacency restriction on loot panel

For devs:
- Makes alt click interactions easier to work with, no more click chain
nonsense and redundant guard clauses.
- OOP hell reduced
- Pascal Case reduced
- Glorious snake case

## Changelog
:cl:
add: The lootpanel now works at range.
add: Screentips for reskinnable items.
fix: Alt click interactions have been refactored, which may lead to
unintentional changes to gameplay. Report any issues, please.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Oversight We have no quality control
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Alt click refactor jlsnow301/tgstation
2 participants
@DATA-xPUNGED @MrMelbert