Alt click refactor #82656
Alt click refactor #82656
Conversation
tgstation-server
added
Fix
jlsnow301
requested review from
Jacquerel,
san7890,
tralezab,
LemonInTheDark,
Time-Green,
MrMelbert,
JohnFulpWillard,
Fikou and
ExcessiveUseOfCobblestone
as code owners
|
breaks like, every alt click interaction. no longer possible to check contents of storage item with alt click, no longer possible to empty fire extinguishers, etc. alt click menu also barely works and will always target the tile you're standing on which breaks being able to move items under flaps and whatnot |
|
having the current iteration of this pr open right now, you can actually open storage with alt click and emptying fire extinguishers does work!
for my own sanity I'mma leave it at that for a bit |
This gets updated pretty quickly, so please make an issue report with a round ID |
|
This is terrible currently. Can't even rotate shit with alt click. Did it override other settings or something? |
|
Yeah, I don't know why I couldn't rotate things. Maybe it was because I was a cyborg in the round? The new loot panel was pretty fucky when I was trying it out. It wouldn't display items on the ground in the loot panel box either when I tried alt clicking the floor. |
Could you elaborate, or better, write an issue with some repro steps?
can cyborgs do this without hands?? edit: found it, fixed |
|
Imagine you want to clear the pad after someone placed some orders on the express. before, you would walk up, alt click it, see the list, and click with your welder active on each listed drop pod. now, it looks like this and you can only click on one drop pod at a time. |
|
wonder what this does |
About The Pull Request
Rewrites how alt click works.
Based heavily on #82625. What a cool concept, it flows nicely with #82533.
Fixes #81242
(tm bugs fixed)
Fixes #82668
More info for devs
Handy regex used for alt click s&r:
AltClick\((.*).*\)(\n\t.*\.\.\(\))?click_alt($1)(yes I am aware this only copies the first arg. there are no other args!)Obj reskins
No reason for obj reskin to check on every single alt click for every object. It applies to only a few items.
Ventcrawling
Every single atmospherics machine checked for ventcrawling capability on alt click despite only 3 objects needing that functionality. This has been moved down to those individual items.
Why It's Good For The Game
For players:
For devs:
Changelog
🆑
add: The lootpanel now works at range.
add: Screentips for reskinnable items.
fix: Alt click interactions have been refactored, which may lead to unintentional changes to gameplay. Report any issues, please.
/:cl: