Custom movement hotkeys and restore macros for T, O and M #47626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
the
Fix
MrPerson
reviewed
Nov 6, 2019
Couls
commented
Nov 6, 2019
Comment on lines
33
to
+38
| /datum/controller/subsystem/input/proc/refresh_client_macro_sets() | ||
| var/list/clients = GLOB.clients | ||
| for(var/i in 1 to clients.len) | ||
| var/client/user = clients[i] | ||
| user.set_macros() | ||
| user.update_movement_keys() |
There was a problem hiding this comment.
don't know if I should rename the proc now that it also updates movement keys after it sets macros
|
Thank god I can play again |
|
You could still make these rebindable a different way, I've got an idea once this is working and merged. |
|
Looking forward to it I鈥檓 interested to see how you鈥檒l do it |
|
Should be ready for review, I kind of want ninja to take a look at it because he's done stuff with input before and this code touches some of the code in the input subsystem |
actioninja
suggested changes
Nov 7, 2019
actioninja
approved these changes
Nov 7, 2019
Closed
tgstation-server
added a commit
that referenced
this pull request
Nov 7, 2019
AustationBot
referenced
this pull request
in austation/austation
Nov 7, 2019
* Custom movement hotkeys and restore macros for T, O and M * stray comma * update movement keys on SSinput initialize * use cardinals
|
You borked everything. Everything is actually unbinded now and people have to change hotkeys in preferences to even move. |
|
There is a way to unbind keys it explains how when you click on the key you wish to unbind Pressing ESC while it listens for key input will unbind the key |
|
Ah, cool. |
|
Bullshit |
|
what? |
yoyobatty
referenced
this pull request
in HippieStation/HippieStationdeprecated2020
Dec 10, 2019
* Port Custom hotkeys from TGMC (#47003) * custom keybindings * Update _lists.dm * Update robot.dm * modify weights and clean up some vars * Update say.dm * Apply suggestions from code review Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com> * some review changes * formatting * include focus hack, remove me_wrapper, give default keybinds to new characters, misc fixes * revert hack and more reviews * remove another focus hack this was causing issues with the keydown proc returning early * Fix loadout tab * fixes modifier hotkeys and adds alternative move intent toggle (#47569) * fixes modifier hotkeys and adds alternative move intent toggle * Fixes pulling keybind * make the wrappers look more like the old popup windows * it was the freaking save file * bump up save file version * reset keybindings to default * Custom movement hotkeys and restore macros for T, O and M (#47626) * Custom movement hotkeys and restore macros for T, O and M * stray comma * update movement keys on SSinput initialize * use cardinals * Add to our DME * ports TGMCs click hack for non-hotkey players ports classic keybinds from TGMC (#47670) About The Pull Request Ports tgstation/TerraGov-Marine-Corps#2977, overrides click proc to return focus back to chat bar using winsets also ports tgstation/TerraGov-Marine-Corps#1904 which has two sets of defaults for hotkey and classic mode fixes #47672 fixes #47659 much credit to @Rohesie and the TGMC team for a bunch of these improvements Why It's Good For The Game lets the non-hotkey players walk and talk again Changelog cl add: Custom keybinds will now check what style (classic / hotkey) you prefer when resetting if you use classic mode make sure to reset your keybinds to default! add: multiple keybind support tweak: non-hotkey mode keeps focus on chat fix: pressing 4 as cyborg now properly cycles fix: AI location hotkeys now work again /cl * Merge pull request #47804 from Couls/fix-savefiles keybindings save file fix * Merge pull request #47750 from ninjanomnom/doafuckinflip Makes every emote keybindable * Hippie stuff * Stuff * Woops
Neo1w
pushed a commit
to Nopm/Beat-Station
that referenced
this pull request
Dec 10, 2019
* Port Custom hotkeys from TGMC (tgstation#47003) * custom keybindings * Update _lists.dm * Update robot.dm * modify weights and clean up some vars * Update say.dm * Apply suggestions from code review Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com> * some review changes * formatting * include focus hack, remove me_wrapper, give default keybinds to new characters, misc fixes * revert hack and more reviews * remove another focus hack this was causing issues with the keydown proc returning early * Fix loadout tab * fixes modifier hotkeys and adds alternative move intent toggle (tgstation#47569) * fixes modifier hotkeys and adds alternative move intent toggle * Fixes pulling keybind * make the wrappers look more like the old popup windows * it was the freaking save file * bump up save file version * reset keybindings to default * Custom movement hotkeys and restore macros for T, O and M (tgstation#47626) * Custom movement hotkeys and restore macros for T, O and M * stray comma * update movement keys on SSinput initialize * use cardinals * Add to our DME * ports TGMCs click hack for non-hotkey players ports classic keybinds from TGMC (tgstation#47670) About The Pull Request Ports tgstation/TerraGov-Marine-Corps#2977, overrides click proc to return focus back to chat bar using winsets also ports tgstation/TerraGov-Marine-Corps#1904 which has two sets of defaults for hotkey and classic mode fixes tgstation#47672 fixes tgstation#47659 much credit to @Rohesie and the TGMC team for a bunch of these improvements Why It's Good For The Game lets the non-hotkey players walk and talk again Changelog cl add: Custom keybinds will now check what style (classic / hotkey) you prefer when resetting if you use classic mode make sure to reset your keybinds to default! add: multiple keybind support tweak: non-hotkey mode keeps focus on chat fix: pressing 4 as cyborg now properly cycles fix: AI location hotkeys now work again /cl * Merge pull request tgstation#47804 from Couls/fix-savefiles keybindings save file fix * Merge pull request tgstation#47750 from ninjanomnom/doafuckinflip Makes every emote keybindable * Hippie stuff * Stuff * Woops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Restores the T, O and M macros so that you can escape out of chat windows and they have an X in the corner, this also prevents the latency you get when you have a high ping and attempt to use T, O or M hotkeys.The downside is that these three keys are no longer customizable. Also adds in custom movement hotkeys
should fix #47621
Why It's Good For The Game
Not every keyboard is QWERTY and this allows people to change the movement keys to whatever they feel comfortable with
Changelog
馃啈
add: Movement keys are now customizable
del: T, O and M are no longer customizable
del: admin commands for messing with movement keys, this won't work since they're different for each client
fix: ooc, say and me are all escapable now and no longer lag at higher pings
/:cl: