Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes every emote keybindable #47750

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Makes every emote keybindable #47750

merged 1 commit into from
Nov 15, 2019

Conversation

ninjanomnom
Copy link
Member

@ninjanomnom ninjanomnom commented Nov 13, 2019 •
edited

馃啈 ninjanomnom
add: You can keybind any emote
/:cl:

image

@tgstation-server tgstation-server added the Feature Exposes new bugs in interesting ways label Nov 13, 2019
@Shadowflame909
Copy link
Contributor

break dancing is now a skill

@RaveRadbury
Copy link
Member

We're dark souls now

Seriously though, how difficult would it be to have like 5 or so blank emote keybinds so players can assign *clap and other emotes as well?

@TheVekter
Copy link
Contributor

Thank fuck. Best change so far. Speedmerge.

@necromanceranne
Copy link
Contributor

I'm binding flip to my mouse 1 so I can flip as I make spessmen horizontal.

@optimumtact
Copy link
Member

you boomers were all complaining about keybinds a second ago

@necromanceranne
Copy link
Contributor

Lol I'm a hotkey zoomer so I didn't even notice any changes at all

@Tlaltecuhtli
Copy link
Contributor

is *fart next?

@MCterra10
Copy link
Contributor

Based and redpilled, now do it for *deathgasp

@carlarctg
Copy link
Contributor

add a spin hotkey too wtg

@nicbn
Copy link
Contributor

nicbn commented Nov 13, 2019

Tactically flip midcombat to avoid being clicked

stonks

@CRITAWAKETS
Copy link
Contributor

*wag hotkey when

@Quartich
Copy link
Contributor

I already had macros bound to my mouse for *flip and *spin

@ninjanomnom
Copy link
Member Author

I realized after I went to bed I should just make all emotes automatically get a keybinding datum rather than do them one at a time like this. Expect that in a bit

@ninjanomnom ninjanomnom changed the title *flip Makes every emote keybindable Nov 13, 2019
@Couls
Copy link
Contributor

Couls commented Nov 13, 2019 •
edited

notices kiss emote 馃槼

@TheVekter
Copy link
Contributor

Okay for real, deathgasp being bound is asking for trouble. Maybe let's not do that one.

@cacogen
Copy link
Contributor

cacogen commented Nov 13, 2019

inb4 emote cooldowns as i spam clap at the speed of light

@PKPenguin321
Copy link
Contributor

you can already do this with external macros :V

@Tharcoonvagh
Copy link
Contributor

WHAT HAVE YOU DONE

@RaveRadbury
Copy link
Member

It's missing *wag and the silicon emotes.

@wesoda25
Copy link
Contributor

It's missing *wag

feature

@optimumtact
Copy link
Member

if you wanted to do species specific emotes you'd probably need another interface of some kind

@ninjanomnom
Copy link
Member Author

Those should be in there, the image just isn't able to show them all because they didn't fit on the screen

@Tharcoonvagh
Copy link
Contributor

Add a cooldown so people won't spam your face and ears and won't act like a budget singularity by binding *flip to wasd

@cacogen
Copy link
Contributor

cacogen commented Nov 14, 2019 •
edited

@Tharcoonvagh

If only anybody tested pull requests (other than the authors, some most of the time) before they were merged. This one will probably add the necessity of an emote cooldown, if only because of the ones with sound. I remember *flip lost its John Fagtron flips! text because of spam (which I guess was before repeat messages were condensed). With a cooldown, emotes that only make sound when triggered involuntarily could have sound all the time too.

Note: I fully support this pull request.

@ShizCalev
Copy link
Member

ShizCalev commented Nov 15, 2019 •
edited

NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE
NEED A DISPENSER HERE

ShizCalev
ShizCalev reviewed Nov 15, 2019
View reviewed changes
Copy link
Member

@ShizCalev ShizCalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this looks good on paper, past experience dictates that this absolutely will be abused.

hard no from me.

@MCterra10
Copy link
Contributor

What exactly is abusable about emotes? With borgs spin might be but that's up for debate. In addition, if you're the type of person who is going to abuse emotes (if they can be), you're the type of person who will just use an AHK script to achieve the same thing

@optimumtact
Copy link
Member

you can already spam emotes with ctrl + up and enter

@optimumtact optimumtact merged commit d279b3e into tgstation:master Nov 15, 2019
tgstation-server added a commit that referenced this pull request Nov 15, 2019
@tgstation-server
Automatic changelog generation for PR #47750 [ci skip]
fa971d9
AustationBot referenced this pull request in austation/austation Nov 15, 2019
@optimumtact @AustationBot
Merge pull request #47750 from ninjanomnom/doafuckinflip
375c463 
Makes every emote keybindable
@AustationBot AustationBot mentioned this pull request Nov 15, 2019
Merged
@Tharcoonvagh
Copy link
Contributor

This is why I'm worried, @cacogen

@Couls
Copy link
Contributor

Couls commented Nov 15, 2019

me after the PR was merged:

ezgif-2-a1f4e6140047

@ninjanomnom ninjanomnom deleted the doafuckinflip branch November 18, 2019 14:36
yoyobatty referenced this pull request in HippieStation/HippieStationdeprecated2020 Dec 10, 2019
@yoyobatty
Port customizable keybinds from /tg/ (#12391)
ac97b0e 
* Port Custom hotkeys from TGMC (#47003)

* custom keybindings

* Update _lists.dm

* Update robot.dm

* modify weights and clean up some vars

* Update say.dm

* Apply suggestions from code review

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>

* some review changes

* formatting

* include focus hack, remove me_wrapper, give default keybinds to new characters, misc fixes

* revert hack and more reviews

* remove another focus hack

this was causing issues with the keydown proc returning early

* Fix loadout tab

* fixes modifier hotkeys and adds alternative move intent toggle (#47569)

* fixes modifier hotkeys and adds alternative move intent toggle

* Fixes pulling keybind

* make the wrappers look more like the old popup windows

* it was the freaking save file

* bump up save file version

* reset keybindings to default

* Custom movement hotkeys and restore macros for T, O and M (#47626)

* Custom movement hotkeys and restore macros for T, O and M

* stray comma

* update movement keys on SSinput initialize

* use cardinals

* Add to our DME

* ports TGMCs click hack for non-hotkey players ports classic keybinds from TGMC (#47670)

About The Pull Request

Ports tgstation/TerraGov-Marine-Corps#2977, overrides click proc to return focus back to chat bar using winsets also ports tgstation/TerraGov-Marine-Corps#1904 which has two sets of defaults for hotkey and classic mode
fixes #47672 fixes #47659

much credit to @Rohesie and the TGMC team for a bunch of these improvements
Why It's Good For The Game

lets the non-hotkey players walk and talk again
Changelog

cl
add: Custom keybinds will now check what style (classic / hotkey) you prefer when resetting if you use classic mode make sure to reset your keybinds to default!
add: multiple keybind support
tweak: non-hotkey mode keeps focus on chat
fix: pressing 4 as cyborg now properly cycles
fix: AI location hotkeys now work again
/cl

* Merge pull request #47804 from Couls/fix-savefiles

keybindings save file fix

* Merge pull request #47750 from ninjanomnom/doafuckinflip

Makes every emote keybindable

* Hippie stuff

* Stuff

* Woops
Neo1w pushed a commit to Nopm/Beat-Station that referenced this pull request Dec 10, 2019
@Neo1w
Port customizable keybinds from /tg/ (tgstation#12391)
b2ec52c 
* Port Custom hotkeys from TGMC (tgstation#47003)

* custom keybindings

* Update _lists.dm

* Update robot.dm

* modify weights and clean up some vars

* Update say.dm

* Apply suggestions from code review

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>

* some review changes

* formatting

* include focus hack, remove me_wrapper, give default keybinds to new characters, misc fixes

* revert hack and more reviews

* remove another focus hack

this was causing issues with the keydown proc returning early

* Fix loadout tab

* fixes modifier hotkeys and adds alternative move intent toggle (tgstation#47569)

* fixes modifier hotkeys and adds alternative move intent toggle

* Fixes pulling keybind

* make the wrappers look more like the old popup windows

* it was the freaking save file

* bump up save file version

* reset keybindings to default

* Custom movement hotkeys and restore macros for T, O and M (tgstation#47626)

* Custom movement hotkeys and restore macros for T, O and M

* stray comma

* update movement keys on SSinput initialize

* use cardinals

* Add to our DME

* ports TGMCs click hack for non-hotkey players ports classic keybinds from TGMC (tgstation#47670)

About The Pull Request

Ports tgstation/TerraGov-Marine-Corps#2977, overrides click proc to return focus back to chat bar using winsets also ports tgstation/TerraGov-Marine-Corps#1904 which has two sets of defaults for hotkey and classic mode
fixes tgstation#47672 fixes tgstation#47659

much credit to @Rohesie and the TGMC team for a bunch of these improvements
Why It's Good For The Game

lets the non-hotkey players walk and talk again
Changelog

cl
add: Custom keybinds will now check what style (classic / hotkey) you prefer when resetting if you use classic mode make sure to reset your keybinds to default!
add: multiple keybind support
tweak: non-hotkey mode keeps focus on chat
fix: pressing 4 as cyborg now properly cycles
fix: AI location hotkeys now work again
/cl

* Merge pull request tgstation#47804 from Couls/fix-savefiles

keybindings save file fix

* Merge pull request tgstation#47750 from ninjanomnom/doafuckinflip

Makes every emote keybindable

* Hippie stuff

* Stuff

* Woops
@Joker66613 Joker66613 mentioned this pull request Jun 29, 2020
Closed
@Johnathon-Baxter Johnathon-Baxter mentioned this pull request Sep 16, 2020
Closed
@nednaZ nednaZ mentioned this pull request Mar 27, 2022
Merged
@ThatLing ThatLing mentioned this pull request Dec 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShizCalev ShizCalev ShizCalev left review comments

@Cyberboss Cyberboss Awaiting requested review from Cyberboss

Assignees
No one assigned
Labels
Feature Exposes new bugs in interesting ways
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet