Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juke Build 0.8.1 #60404

Merged
merged 4 commits into from Aug 15, 2021
Merged

Juke Build 0.8.1 #60404

merged 4 commits into from Aug 15, 2021

Conversation

stylemistake
Copy link
Member

@stylemistake stylemistake commented Jul 23, 2021

About The Pull Request

With this PR, I have decided to move some build, test and lint related tasks to build.js.

Here is a full list of targets/parameters, to get a taste of what you can run with this thing:

$ tools/build/build --help
:: Juke Build version 0.8.1
:: Available targets:
 - all
 - build
 - clean
 - dist-clean
 - dm-maps-include
 - dm
 - dm-test
 - lint
 - server
 - test
 - tg-font
 - tgs
 - tgui-analyze
 - tgui-dev
 - tgui-eslint
 - tgui-lint
 - tgui
 - tgui-test
 - tgui-tsc
 - yarn
:: Available parameters:
 --ci (type: boolean)
 --define, -D (type: string[])
 --port, -p (type: string)
  • server compiles and hosts the server in one go.
    • tools/build/build server --port 10050
  • test runs DM unit tests.
  • all runs all of the above in the most efficient manner.

Updated the CI pipeline to reflect this change, removed the python script to generate a list of map includes (because build.js now does it automatically based on provided defines). Added restoring of Yarn cache in CI, which saves about a minute.

A lot of small improvements to Juke, detailed changelog is here.

Changed .mdme extension to .m.dme because it results in a more organized set of files, i.e. .m.dme, .m.dmb, .m.rsc.

Bumped node version because earlier versions do not support ES modules without extra experimental flags.

Added THREE new bat files for dummies:

  • CLEAN.bat (for fixing random issues)
  • RUN_TESTS.bat for an offline CI run.
  • RUN_SERVER.bat for running the server, very simple (default port is 1337).

@stylemistake stylemistake added Tools We pretend to be a real development community Refactor Makes the code harder to read Verified ✔️ Yeah, i'm a coder. What about it? javascript You can't keep this language out of infecting any major project labels Jul 23, 2021
@tgstation-server tgstation-server added the GitHub Remember that time they had to get us to send them a copy of the repo label Jul 23, 2021
@stylemistake stylemistake changed the title Juke 0.7.0: Junglist Massive Edition Juke Build 0.7.0: Junglist Massive Jul 23, 2021
@stylemistake
Copy link
Member Author

stylemistake commented Jul 23, 2021

:: bash('tools/ci/check_grep.sh')

dm-test task for some reason dies on this command (never finishes), and somehow the whole thing returns a non-zero exit code. 👀

@Mothblocks Mothblocks self-assigned this Jul 23, 2021
@stylemistake
Copy link
Member Author

I will have to convert this to a draft until I find some time to fix this.

@stylemistake stylemistake marked this pull request as draft July 28, 2021 08:09
Copy link
Member

@Mothblocks Mothblocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over the parts that touched and transferred CI, all looks good.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2021

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label Aug 5, 2021
@stylemistake stylemistake reopened this Aug 12, 2021
@tgstation-server tgstation-server added the UI We make the game less playable, but with round edges label Aug 12, 2021
@stylemistake stylemistake changed the title Juke Build 0.7.0: Junglist Massive Juke Build 0.8.1: Junglist Massive Aug 12, 2021
@stylemistake stylemistake marked this pull request as ready for review August 12, 2021 19:18
@stylemistake
Copy link
Member Author

stylemistake commented Aug 12, 2021

Ready for merge again, I have reverted changes to the dm lint part, because it's too flaky and too environment-dependent for inclusion in Juke.

@stylemistake stylemistake changed the title Juke Build 0.8.1: Junglist Massive Juke Build 0.8.1: Resurrection Aug 12, 2021
@stylemistake stylemistake removed the Stale Even the uncaring universe rejects you, why even go on label Aug 14, 2021
@stylemistake stylemistake changed the title Juke Build 0.8.1: Resurrection Juke Build 0.8.1 Aug 15, 2021
@Mothblocks Mothblocks merged commit e5ae066 into tgstation:master Aug 15, 2021
github-actions bot added a commit that referenced this pull request Aug 15, 2021
@stylemistake stylemistake deleted the juke-build branch August 15, 2021 22:24
BraveMole pushed a commit to tgstation/TerraGov-Marine-Corps that referenced this pull request Oct 15, 2021
* i should have split this into different commits but
tgstation/tgstation#60695
tgstation/tgstation#60736
tgstation/tgstation#60775
tgstation/tgstation#60859

* Juke build 0.8.1/0.9.0/0.8.1 revert
tgstation/tgstation#60404
tgstation/tgstation#60897
tgstation/tgstation#61025
tgstation/tgstation#61110
tgstation/tgstation#61005

* allow cancel tgui alert
tgstation/tgstation#61072

* TGUI bench
tgstation/tgstation#61081

* upgrade stuff from tgstation/tgstation#61313

* component stuff from tgstation/tgstation#61381

* improvements from:
tgstation/tgstation#61925
tgstation/tgstation#61496
tgstation/tgstation#61381

* aaaaaaaaaaaa

* linter errors

* no strictnullcheckyet

* Tooltip:
tgstation/tgstation#61783
and types.ts i forgot

* oops

* i hate git why was this still here

* stuff i forgot

* aaa

* strictnullchecks fixes

* button stuff i jumped

* TGUI tasks
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Dec 12, 2021
* Juke Build 0.8.1 (tgstation#60404)

* Juke Build 0.8.1

Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Remember that time they had to get us to send them a copy of the repo javascript You can't keep this language out of infecting any major project Refactor Makes the code harder to read Tools We pretend to be a real development community UI We make the game less playable, but with round edges Verified ✔️ Yeah, i'm a coder. What about it?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants