Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds logging for mob numbers #60695

Merged
merged 1 commit into from Aug 5, 2021
Merged

Conversation

dragomagol
Copy link
Member

@dragomagol dragomagol commented Aug 3, 2021

About The Pull Request

Adds an additional log file, mob_tag.log, where ownership and naming of mobs by mob number can be found. Output looks something like this:

[2021-08-03 22:05:00.572] TAG: [mob_201] CREATED: no key/(goliath)
[2021-08-03 22:05:00.573] TAG: [mob_202] CREATED: no key/(legion)
[2021-08-03 22:05:00.573] TAG: [mob_203] CREATED: no key/(goliath)
[2021-08-03 22:05:14.418] TAG: [mob_204] CREATED: no key/(Ava Ringer)
[2021-08-03 22:05:14.445] TAG: [mob_204] NEW OWNER: Guest-2904817265/(Braylon Anderson)
[2021-08-03 22:05:14.481] TAG: [mob_205] CREATED: no key/(Jaelyn Brooks)
[2021-08-03 22:05:32.499] TAG: [mob_206] CREATED: no key/(legion)
[2021-08-03 22:05:32.500] TAG: [mob_207] CREATED: no key/(watcher)
[2021-08-03 22:05:32.502] TAG: [mob_208] CREATED: no key/(goliath)
[2021-08-03 22:05:32.503] TAG: [mob_209] CREATED: no key/(legion)
[2021-08-03 22:05:32.504] TAG: [mob_210] CREATED: no key/(goliath)
[2021-08-03 22:05:36.555] TAG: [mob_204] RENAMED: Guest-2904817265/(Walter Jones)

Why It's Good For The Game

Href and TGUI logging is great, but it has shortcomings in the form of references to players and mobs. Here's an example of what a TGUI orbit log looks like:

[CKEY] (as [NAME] at 107,133,2) in tgui-window-1

  • Using: /datum/orbit_menu [0x2101bbb0]
  • Action: orbit {"ref":"[mob_437]"}

Who is mob_437? If the round's over there's no way to know. This log will keep track of those relationships for later.

Changelog

馃啈
admin: adds an additional log file, mob_tags, for referencing mob numbers in logs
/:cl:

@tgstation-server tgstation-server added Administration As generous gods, we have deigned to throw the jannies a bone and removed Administration As generous gods, we have deigned to throw the jannies a bone labels Aug 3, 2021
@Fikou Fikou added the Logging printf("Here"); printf("Here2"); printf("Heree"); label Aug 5, 2021
@Mothblocks Mothblocks merged commit a38f11a into tgstation:master Aug 5, 2021
github-actions bot added a commit that referenced this pull request Aug 5, 2021
Mothblocks pushed a commit to Mothblocks/tgstation that referenced this pull request Aug 9, 2021
Mothblocks pushed a commit to Mothblocks/tgstation that referenced this pull request Aug 9, 2021
BraveMole pushed a commit to tgstation/TerraGov-Marine-Corps that referenced this pull request Oct 15, 2021
* i should have split this into different commits but
tgstation/tgstation#60695
tgstation/tgstation#60736
tgstation/tgstation#60775
tgstation/tgstation#60859

* Juke build 0.8.1/0.9.0/0.8.1 revert
tgstation/tgstation#60404
tgstation/tgstation#60897
tgstation/tgstation#61025
tgstation/tgstation#61110
tgstation/tgstation#61005

* allow cancel tgui alert
tgstation/tgstation#61072

* TGUI bench
tgstation/tgstation#61081

* upgrade stuff from tgstation/tgstation#61313

* component stuff from tgstation/tgstation#61381

* improvements from:
tgstation/tgstation#61925
tgstation/tgstation#61496
tgstation/tgstation#61381

* aaaaaaaaaaaa

* linter errors

* no strictnullcheckyet

* Tooltip:
tgstation/tgstation#61783
and types.ts i forgot

* oops

* i hate git why was this still here

* stuff i forgot

* aaa

* strictnullchecks fixes

* button stuff i jumped

* TGUI tasks
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Dec 12, 2021
* add logging to mob numbers (tgstation#60695)

* Adds logging for mob numbers

Co-authored-by: dragomagol <66640614+dragomagol@users.noreply.github.com>
@dragomagol dragomagol deleted the cat-vore branch August 12, 2022 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Logging printf("Here"); printf("Here2"); printf("Heree");
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants