resprites all soda cans, adds wellcheers juice #77424
Conversation
CoiledLamb
requested review from
Imaginos16,
Krysonism,
Twaticus,
Wallemations and
ExcessiveUseOfCobblestone
as code owners
tgstation-server
added
Sprites
|
The six pack sprite has definitely needed some love, thank you for your service |
shit i should've had a before after for that one too lmao |
|
a lot of these i dont get the changes. changing the 4th one to be some weird symbol rather than steam coming out of a drink? changing the 6th one to be fire? changing the 9th one to remove the balloon and just have a random line? changing the 11th one to just be like a sun rather than what appears to be something implying a race? the 16th one is too boring now. these ones are just downgrades or misinterpretations of what it was, not even arguing for "soul" (although the old sprites arent even bad) |
the ones you're mentioning are literally so vague i could not parse them when redesigning them. i'm not even sure you know what they're meant to represent? |
|
which is the before and which is the after genuine question |
top is before bottom is after |
It's Canada Dry, it looks like the can. The creator of the ginger ale would prefer that it remain modeled after Canada Dry |
no offense to the creator but i'm personally much more fond of the sun design than i would be making it a reference to a real world product. |
the new one looks lower effort. it stands out as being plainer than all of the other new cans. a lot of the sodas are based on real drinks and have designs that reflect that. it's part of the point of it all, making signs and symbols that relate to irl things so they are comprehendible. |
|
why the shamblers juice became neon green |
yeah i agree, i didnt want to be the one that said it but it looks very lazy and low-effort, its barely even a design, its just some dots and a circle and doesnt look like itd resemble anything, maybe some cleaning spray i guess (i get that its very limited pixels but its not an excuse) |
|
Big + on the new drink, it has cute effects that change depending on the mood. I'm a big fan of small little tricks you can pick up like that, and having it have small yet so variable effects on your mood just feels right and satisfying. Honestly makes me want to add effects to all the other bland, boring space cola cans that don't do anything. |
|
The 'new' sol dry sprite is fine. It looks nice and clean, if maybe a bit lacking in detail, but the old one is pretty much completely unintelligible and a pixellated mess because, shocker, real life elaborate can designs designed to catch your attention don't translate to tiny 4x8 pixel art. Let's not nitpick what every single Can looks like? |
it's the eldritch version (which was already green), the og shamblers is still ourple |
|
also the sol dry is my favorite new logo of the lot so callin' it low effort is not really swaying me on redesigning it, i'll be honest. sometimes a simpler design is better. not everything has to exactly resemble an irl product in this sci fi game set 500 yrs in the future |
|
why are a few slightly different cans so controversial |
"i like it" isnt really an argument, at all, just because you like it doesnt make it good, or change the fact that its boring and low-effort |
I think it's pretty neat tbh canada dry looks boring |
since I did the resprite, you would have to convince me that it's worth changing due to your complaints for me to actually bother with it. and like I said, no matter how boring or low effort you think it is, I like it. as long as y'all keep trying to tear it down, I'll be satisfied with it, so maybe change your plan of attack or take up sprite art if you want something different. |
i have plenty of friends here :P and i don't want to make friends with people that don't value the work i put in to my sprites. if you think my work is boring and low effort, so be it. |
## About The Pull Request this one was a labor of love. all the existing soda cans have been resprited, with the help of @retlaw34 (new top palettes), @Imaginos16 (new top shapes, can palettes), and some original sprites done by @Krysonism (monkey energy, the 13 loko). you can see the before and afters here:  (now includes crushed cans, and inhands!) let me know if there's any promotional stuff i should also include in this PR, like if sol dry has a poster somewhere, and i'll go update that with any changes made. also adds a new drink, idea courtesy of @YesterdaysPromise: wellcheers juice!  it will make you drowsy, and has a variable affect on your mood if you are unhappy, it will deal stamina damage if you are neutral, it will give you a mood boost if you are happy, it will heal some brute damage also, six packs of cans have been resprited. can i interest anyone in an alamo? or just a space beer?  ## Why It's Good For The Game old can sprites were _crusty_. it was nearly impossible to tell what some of the logos were, and the palettes were dated as well. this tries to keep the logo similar where possible, giving them new life where i can, and sometimes reimagining them. the result is still internally consistent, but much more polished. ## Changelog :cl: add: Added wellcheers, a contraband soda with various side effects. image: resprites all cans in the drinks icon file image: resprites the canholder sprite in storage.dmi /:cl:
…7210) Original PR: tgstation/tgstation#77424 ----- ## About The Pull Request this one was a labor of love. all the existing soda cans have been resprited, with the help of retlaw34 (new top palettes), Imaginos16 (new top shapes, can palettes), and some original sprites done by Krysonism (monkey energy, the 13 loko). you can see the before and afters here:  (now includes crushed cans, and inhands!) let me know if there's any promotional stuff i should also include in this PR, like if sol dry has a poster somewhere, and i'll go update that with any changes made. also adds a new drink, idea courtesy of YesterdaysPromise: wellcheers juice!  it will make you drowsy, and has a variable affect on your mood if you are unhappy, it will deal stamina damage if you are neutral, it will give you a mood boost if you are happy, it will heal some brute damage also, six packs of cans have been resprited. can i interest anyone in an alamo? or just a space beer?  ## Why It's Good For The Game old can sprites were _crusty_. it was nearly impossible to tell what some of the logos were, and the palettes were dated as well. this tries to keep the logo similar where possible, giving them new life where i can, and sometimes reimagining them. the result is still internally consistent, but much more polished. ## Changelog :cl: add: Added wellcheers, a contraband soda with various side effects. image: resprites all cans in the drinks icon file image: resprites the canholder sprite in storage.dmi /:cl: --------- Co-authored-by: Lamb <110322848+CoiledLamb@users.noreply.github.com>
…77757) ## About The Pull Request this is kind of a miscellaneous pile of fixes for soda.dmi, rolled up with a larger resprite of the new cans that were added with #75988. you can see everything visually changed (other than inhands) in the image below  and then the inhands here:  also changes wellcheers mood event text, and the mood switch to be based on sanity instead. apparently the mood test allowed for foolproof traitor testing, which is not ideal. this hopefully fixes that. ## Why It's Good For The Game the new martian drinks used the previous style of cans, which was updated in #77424. this makes them consistent with that style. everything else is minor things i missed or forgot to do in that PR. also things that enable traitor testing are not great, even if they're niche and require amputation to pull off. ## Changelog :cl: fix: wellcheers is now based on sanity rather than mood image: resprites martian cans image: adds inhands for martian cans and wellcheers image: minor tweaks to other cans spellcheck: updates wellcheers mood text /:cl:
…#77757) ## About The Pull Request this is kind of a miscellaneous pile of fixes for soda.dmi, rolled up with a larger resprite of the new cans that were added with #75988. you can see everything visually changed (other than inhands) in the image below  and then the inhands here:  also changes wellcheers mood event text, and the mood switch to be based on sanity instead. apparently the mood test allowed for foolproof traitor testing, which is not ideal. this hopefully fixes that. ## Why It's Good For The Game the new martian drinks used the previous style of cans, which was updated in #77424. this makes them consistent with that style. everything else is minor things i missed or forgot to do in that PR. also things that enable traitor testing are not great, even if they're niche and require amputation to pull off. ## Changelog :cl: fix: wellcheers is now based on sanity rather than mood image: resprites martian cans image: adds inhands for martian cans and wellcheers image: minor tweaks to other cans spellcheck: updates wellcheers mood text /:cl:
this one was a labor of love. all the existing soda cans have been resprited, with the help of @retlaw34 (new top palettes), @Imaginos16 (new top shapes, can palettes), and some original sprites done by @Krysonism (monkey energy, the 13 loko). you can see the before and afters here:  (now includes crushed cans, and inhands!) let me know if there's any promotional stuff i should also include in this PR, like if sol dry has a poster somewhere, and i'll go update that with any changes made. also adds a new drink, idea courtesy of @YesterdaysPromise: wellcheers juice!  it will make you drowsy, and has a variable affect on your mood if you are unhappy, it will deal stamina damage if you are neutral, it will give you a mood boost if you are happy, it will heal some brute damage also, six packs of cans have been resprited. can i interest anyone in an alamo? or just a space beer?  old can sprites were _crusty_. it was nearly impossible to tell what some of the logos were, and the palettes were dated as well. this tries to keep the logo similar where possible, giving them new life where i can, and sometimes reimagining them. the result is still internally consistent, but much more polished. :cl: add: Added wellcheers, a contraband soda with various side effects. image: resprites all cans in the drinks icon file image: resprites the canholder sprite in storage.dmi /:cl:
this one was a labor of love. all the existing soda cans have been resprited, with the help of @retlaw34 (new top palettes), @Imaginos16 (new top shapes, can palettes), and some original sprites done by @Krysonism (monkey energy, the 13 loko). you can see the before and afters here:  (now includes crushed cans, and inhands!) let me know if there's any promotional stuff i should also include in this PR, like if sol dry has a poster somewhere, and i'll go update that with any changes made. also adds a new drink, idea courtesy of @YesterdaysPromise: wellcheers juice!  it will make you drowsy, and has a variable affect on your mood if you are unhappy, it will deal stamina damage if you are neutral, it will give you a mood boost if you are happy, it will heal some brute damage also, six packs of cans have been resprited. can i interest anyone in an alamo? or just a space beer?  old can sprites were _crusty_. it was nearly impossible to tell what some of the logos were, and the palettes were dated as well. this tries to keep the logo similar where possible, giving them new life where i can, and sometimes reimagining them. the result is still internally consistent, but much more polished. :cl: add: Added wellcheers, a contraband soda with various side effects. image: resprites all cans in the drinks icon file image: resprites the canholder sprite in storage.dmi /:cl:
this one was a labor of love. all the existing soda cans have been resprited, with the help of @retlaw34 (new top palettes), @Imaginos16 (new top shapes, can palettes), and some original sprites done by @Krysonism (monkey energy, the 13 loko). you can see the before and afters here:  (now includes crushed cans, and inhands!) let me know if there's any promotional stuff i should also include in this PR, like if sol dry has a poster somewhere, and i'll go update that with any changes made. also adds a new drink, idea courtesy of @YesterdaysPromise: wellcheers juice!  it will make you drowsy, and has a variable affect on your mood if you are unhappy, it will deal stamina damage if you are neutral, it will give you a mood boost if you are happy, it will heal some brute damage also, six packs of cans have been resprited. can i interest anyone in an alamo? or just a space beer?  old can sprites were _crusty_. it was nearly impossible to tell what some of the logos were, and the palettes were dated as well. this tries to keep the logo similar where possible, giving them new life where i can, and sometimes reimagining them. the result is still internally consistent, but much more polished. :cl: add: Added wellcheers, a contraband soda with various side effects. image: resprites all cans in the drinks icon file image: resprites the canholder sprite in storage.dmi /:cl:
[Port] resprites all soda cans, adds wellcheers juice tgstation#77424 + Fix for dirty ice cups
…gstation#77757) this is kind of a miscellaneous pile of fixes for soda.dmi, rolled up with a larger resprite of the new cans that were added with tgstation#75988. you can see everything visually changed (other than inhands) in the image below  and then the inhands here:  also changes wellcheers mood event text, and the mood switch to be based on sanity instead. apparently the mood test allowed for foolproof traitor testing, which is not ideal. this hopefully fixes that. the new martian drinks used the previous style of cans, which was updated in tgstation#77424. this makes them consistent with that style. everything else is minor things i missed or forgot to do in that PR. also things that enable traitor testing are not great, even if they're niche and require amputation to pull off. :cl: fix: wellcheers is now based on sanity rather than mood image: resprites martian cans image: adds inhands for martian cans and wellcheers image: minor tweaks to other cans spellcheck: updates wellcheers mood text /:cl:
* Split drinks into different files (tgstation#75898) Splits our nearly 4000 and 1600 line long files. Mostly just moves the glass appearances into their own files. * undoes removals of some bypass restrictions & metabolized_traits related things * removed changes to on_hydroponics_apply() * we had more arguments, missed that * sigh * Martian Food: A Taste of the Red Planet (tgstation#75988) Adds a selection of new foods and drinks based around Mars. More information on Mars can be found here: https://github.com/tgstation/common_core/blob/master/Interesting%20Planets/Human%20Space/The%20Sol%20System.md To summarise for the general audience, Mars is a vital colony of the Terran Federation, having been primarily settled (at least originally) by Cybersun Industries to harvest its lucrative supplies of plasma, the second largest in human space behind Lavaland. This has given Mars a diverse culture evolving from the mostly East Asian colonists, and their food reflects this. Thanks to Melbert for their work on the soup portion of this PR. The food: Martian cuisine draws upon the culinary traditions of East Asia, and adds in fusion cuisine from the later colonists. Expect classics such as ramen, curry, noodles and donburi, as well as new takes on the formula like the Croque-Martienne, Peanut Butter Ice Cream Mochi, and the Kitzushi- chilli cheese and rice inside a fried tofu casing. Oh, and lots of pineapple. The Martians love pineapple:  Also included are some foods for Ethereals, which may or may not be hinting at something I've got planned... The drinks: Four new base drinks make their way to the game, bringing with them a host of new cocktails: enjoy new ventures in bartending with Coconut Rum, Shochu/Soju, Yuyake (our favourite legally-distinct melon liqueur), and Mars' favourite alcoholic beverage, rice beer. Each is available in the dispenser, as well as bottles in the booze-o-mat:  The recipes: To make your (and the wiki editors) lives easier, please find below the recipes for both foods and drinks: Food: https://hackmd.io/@EOBGames/BkVFU0w9Y Drinks: https://hackmd.io/@EOBGames/rJ1OhnsJ2 Another lot of variety for the chef and bartender, as well as continuing the work started with lizard and moth food in getting Common Core into the game in a tangible and fun way. :cl: EOBGames, MrMelbert add: Mars celebrates the 250th anniversary of the Martian Concession this year, and this has brought Martian cuisine to new heights of popularity. Find a new selection of Martian foods and drinks available in your crafting menu today! /:cl: --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> * updates martian can sprites, fixes misc text and bugs in wellcheers (tgstation#77757) this is kind of a miscellaneous pile of fixes for soda.dmi, rolled up with a larger resprite of the new cans that were added with tgstation#75988. you can see everything visually changed (other than inhands) in the image below  and then the inhands here:  also changes wellcheers mood event text, and the mood switch to be based on sanity instead. apparently the mood test allowed for foolproof traitor testing, which is not ideal. this hopefully fixes that. the new martian drinks used the previous style of cans, which was updated in tgstation#77424. this makes them consistent with that style. everything else is minor things i missed or forgot to do in that PR. also things that enable traitor testing are not great, even if they're niche and require amputation to pull off. :cl: fix: wellcheers is now based on sanity rather than mood image: resprites martian cans image: adds inhands for martian cans and wellcheers image: minor tweaks to other cans spellcheck: updates wellcheers mood text /:cl: * Removing enriched liquid electricity references * look, icons are hard * boiled rice now needs to be boiled and recipe guide for boiled spaghetti/rice * martian hotfix (tgstation#77562) ## About The Pull Request Fixes a few issues with Martian food. Makes stuff that's cooked on the grill or oven not burn, and adds guide recipes for the non-crafting-menu stuff. ## Why It's Good For The Game Fixes some problems, removes some confusion ## Changelog :cl: fix: a few issues with Martian food /:cl: * removed references to butter slices for now * Change from improvised medicine * better block comment formating --------- Co-authored-by: tattle <66640614+dragomagol@users.noreply.github.com> Co-authored-by: EOBGames <58124831+EOBGames@users.noreply.github.com> Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: Lamb <110322848+CoiledLamb@users.noreply.github.com>
About The Pull Request
this one was a labor of love. all the existing soda cans have been resprited, with the help of @retlaw34 (new top palettes), @Imaginos16 (new top shapes, can palettes), and some original sprites done by @Krysonism (monkey energy, the 13 loko).
you can see the before and afters here:
(now includes crushed cans, and inhands!)
let me know if there's any promotional stuff i should also include in this PR, like if sol dry has a poster somewhere, and i'll go update that with any changes made.
also adds a new drink, idea courtesy of @YesterdaysPromise:
wellcheers juice!
it will make you drowsy, and has a variable affect on your mood
if you are unhappy, it will deal stamina damage
if you are neutral, it will give you a mood boost
if you are happy, it will heal some brute damage
also, six packs of cans have been resprited. can i interest anyone in an alamo? or just a space beer?
Why It's Good For The Game
old can sprites were crusty. it was nearly impossible to tell what some of the logos were, and the palettes were dated as well. this tries to keep the logo similar where possible, giving them new life where i can, and sometimes reimagining them. the result is still internally consistent, but much more polished.
Changelog
🆑
add: Added wellcheers, a contraband soda with various side effects.
image: resprites all cans in the drinks icon file
image: resprites the canholder sprite in storage.dmi
/:cl: