Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Download Error (Every Song/Video) #1308

Closed
2 tasks done
Mendungo opened this issue Oct 11, 2023 · 11 comments · Fixed by #1310
Closed
2 tasks done

[Bug]: Download Error (Every Song/Video) #1308

Mendungo opened this issue Oct 11, 2023 · 11 comments · Fixed by #1310
Labels
bug Something isn't working fix-available A fix to the issue is available in a new version

Comments

@Mendungo
Copy link

Preflight Checklist

  • I use the latest version of YouTube Music (Application).
  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

YouTube Music (Application) Version

2.0.4

What operating system are you using?

Windows

Operating System Version

Windows 11

What arch are you using?

x64

Last Known Working YouTube Music (Application) version

No response

Expected Behavior

Download song to specific foler

Actual Behavior

Error message pops up saying "video not found" with every song

Additional Information

No response

@JellyBrick JellyBrick added cannot-reproduce Bug cannot be reproduced need more information Need more information about the issue labels Oct 12, 2023
@JellyBrick
Copy link
Collaborator

JellyBrick commented Oct 12, 2023

It works well for me. Do you have a reproduction process? (What video, what playlist, etc)

@JellyBrick JellyBrick added the awaiting-reply Awaiting reply label Oct 12, 2023
@da-anda
Copy link

da-anda commented Oct 12, 2023

downloading seems to be hit and miss for me. Like downloading a playlist (like the "thumbs up" playlist) doesn't really do anything. I have turned on "skip existing", but there is not even a folder for the playlist in the download directory, so no idea why it would skip anything.

Side note, not related to the general download errors but also a download related issue: When I change the download preset to opus, the result is not opus, but the raw AAC (audio/mp4; codecs="mp4a.40.2") stream with a .opus file extension and no metadata at all. I would have expected to get the unaltered opus stream in the highest available quality. Alternatively a AAC/mp4 preset to get the unaltered highest quality available might make sense.

edit: after a "force reload" I now also get the "video not found error on anything I click

@JellyBrick
Copy link
Collaborator

JellyBrick commented Oct 12, 2023

downloading seems to be hit and miss for me. Like downloading a playlist (like the "thumbs up" playlist) doesn't really do anything. I have turned on "skip existing", but there is not even a folder for the playlist in the download directory, so no idea why it would skip anything.

  • Unfortunately, the 'thumb up' playlist or automatically generated playlist by the system cannot be downloaded, which is YouTube's intended behavior.

Side note, not related to the general download errors but also a download related issue: When I change the download preset to opus, the result is not opus, but the raw AAC (audio/mp4; codecs="mp4a.40.2") stream with a .opus file extension and no metadata at all. I would have expected to get the unaltered opus stream in the highest available quality. Alternatively a AAC/mp4 preset to get the unaltered highest quality available might make sense.

edit: after a "force reload" I now also get the "video not found error on anything I click

  • The current code is designed to download the audio track with the "highest" quality. However, it does not consider the case where the highest quality is the 'm4a' format, so the downloader plugin downloads 'm4a' files with the wrong extension.
    • I plan to improve downloader features to automatically detect the format and choose the appropriate file extension.

@Mendungo
Copy link
Author

Mendungo commented Oct 13, 2023

It works well for me. Do you have a reproduction process? (What video, what playlist, etc)

It doesn't for me, it was working perfectly previously. None of my playlists or songs, not even any individual song, once I click download this is what pops up

Screenshot 2023-10-12 152212

Had to downgrade to 2.0.3, and downloading works fine but now when i try to download a full playlist in bulk it downloads only the one song in playback.

@meequrox
Copy link

Same for me on 2.0.4:

I added some console.log() to back.ts.

To downloadSong() definition:

console.log("downloadSong(%s, %s, %s, _)", url, playlistFolder, trackId);

To downloadSongUnsafe definition:

  console.log("downloadSongUnsafe(%d, %s, _, %s, %s, _)", isId, idOrUrl, playlistFolder, trackId); // <---

  sendFeedback('Downloading...', 2);

  console.log("Start resolving id"); // <---

  let id: string | null;
  if (isId) {
    id = idOrUrl;
    console.log("id = %s", id); // <---
  } else {
    id = getVideoId(idOrUrl);
    console.log("id = %s", id); // <---
    if (typeof id !== 'string') throw new Error('Video not found');
  }

  console.log("Id resolved"); // <---

  let info: TrackInfo | VideoInfo = await yt.music.getInfo(id);

Output in the situation shown in the screenshot above:

downloadSong(https://music.youtube.com/search?q=new+episode, undefined, undefined, _)
downloadSongUnsafe(0, https://music.youtube.com/search?q=new+episode, _, undefined, undefined, _)
Start resolving id
id = null
Error: Video not found

Downloading in older versions also does not work.

@JellyBrick
Copy link
Collaborator

JellyBrick commented Oct 13, 2023

image

Thank you for the detailed bug report! @meequrox @Mendungo @da-anda
An invalid query selector (tabindex="0") caused this issue.

It should be fixed in bf9e3b5.
I'll release a hotfix soon!

@JellyBrick JellyBrick added bug Something isn't working fix-available A fix to the issue is available in a new version and removed cannot-reproduce Bug cannot be reproduced awaiting-reply Awaiting reply need more information Need more information about the issue labels Oct 13, 2023
@JellyBrick
Copy link
Collaborator

JellyBrick commented Oct 13, 2023

@Mendungo

Side note, not related to the general download errors but also a download related issue: When I change the download preset to opus, the result is not opus, but the raw AAC (audio/mp4; codecs="mp4a.40.2") stream with a .opus file extension and no metadata at all. I would have expected to get the unaltered opus stream in the highest available quality. Alternatively a AAC/mp4 preset to get the unaltered highest quality available might make sense.

It should fixed in #1310

@Zahav88
Copy link

Zahav88 commented Jan 6, 2024

I have this issue for quite long time, its possible to download only few songs, rest fails yesterday installed 3.2.1 and all worked again. Today, oh look another new version... bam again does not work!

@JellyBrick
Copy link
Collaborator

@Zahav88 Please provide the reproduction steps

@Zahav88
Copy link

Zahav88 commented Jan 6, 2024

Capture
Capture-2

Not sure if it helps,

@Arusu12
Copy link

Arusu12 commented Jul 29, 2024

image
I am having this error. Using for the first time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix-available A fix to the issue is available in a new version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants