Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mpris + obs-tuna fixes #480

Merged
merged 8 commits into from
Dec 2, 2021
Merged

Mpris + obs-tuna fixes #480

merged 8 commits into from
Dec 2, 2021

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Nov 10, 2021

I've been testing on discord with @JoeJoeTV (many thanks for all the hours invested 😃 ) and we managed to fix all mpris issues (play/pause not working + update progress attribute + seek from mpris + seek to mpris)
should close #372

original comment with mpris bugs: #65 (comment)

docs:
https://www.npmjs.com/package/mpris-service
https://github.com/dbusjs/mpris-service/blob/master/src/index.js#L26-L132
https://github.com/dbusjs/mpris-service/search?q=seeked
https://github.com/dbusjs/mpris-service/blob/master/examples/player.js

For obs-tuna this implements a live update to the progress

also fix #487 by changing status from Playing/Paused to playing/stopped

this pr also adds a songInfo.album for both mpris and tuna (when available, never is available if current song has a video)

ps. mpris could maybe be moved to its own plugin instead of 'camping' inside the shortcuts plugin

@mesmerx
Copy link
Contributor

mesmerx commented Nov 11, 2021

great work man, i planning to try add this feature(time update) in this week, i`ll try that ASAP

@mesmerx
Copy link
Contributor

mesmerx commented Nov 16, 2021

as i can test seems to be ok, i`ll try in a clean env just to make sure

Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, thanks for the contribution! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tuna-OBS] Playback status stuck on unknown Integration with OBS Tuna
3 participants