-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mpris + obs-tuna fixes #480
Merged
Merged
+144
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
great work man, i planning to try add this feature(time update) in this week, i`ll try that ASAP |
as i can test seems to be ok, i`ll try in a clean env just to make sure |
th-ch
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, thanks for the contribution! ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been testing on discord with @JoeJoeTV (many thanks for all the hours invested 😃 ) and we managed to fix all mpris issues (play/pause not working + update progress attribute + seek from mpris + seek to mpris)
should close #372
original comment with mpris bugs: #65 (comment)
For obs-tuna this implements a live update to the progress
also fix #487 by changing status from
Playing
/Paused
toplaying
/stopped
this pr also adds a songInfo.album for both mpris and tuna (when available, never is available if current song has a video)