Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #264

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Update PR template #264

merged 1 commit into from
Jun 5, 2020

Conversation

tupaschoal
Copy link
Collaborator

I made most of the things comments, so contributors only have a guidance on what to write, but don't have to keep erasing stuff that was not applicable, like I did :D

I also suggested using "Closes #XXX" to make sure the PR closes the related issue and we don't have to keep doing housecleaning.

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #264 into master will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage   55.12%   55.08%   -0.05%     
==========================================
  Files          13       13              
  Lines        1219     1220       +1     
  Branches      217      218       +1     
==========================================
  Hits          672      672              
  Misses        480      480              
- Partials       67       68       +1     
Impacted Files Coverage Δ
main.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f33cd2...cdf553a. Read the comment docs.

@thamara thamara merged commit 2b83cea into master Jun 5, 2020
@tupaschoal tupaschoal deleted the new-pr-template branch June 5, 2020 03:24
@tupaschoal tupaschoal added this to the v1.5.3 milestone Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants