Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upload to Netlify feature #92

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

kx-chen
Copy link
Contributor

@kx-chen kx-chen commented Nov 21, 2018

Add functionality to allow user to upload generate files to Netlify

Closes #82

Copy link

@andrewda andrewda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@kx-chen kx-chen force-pushed the deploy-to-netlify branch 2 times, most recently from 822066e to 0953c84 Compare November 21, 2018 05:57
statik/upload.py Outdated Show resolved Hide resolved
statik/cmdline.py Show resolved Hide resolved
statik/cmdline.py Show resolved Hide resolved
README.md Show resolved Hide resolved
@kx-chen
Copy link
Contributor Author

kx-chen commented Nov 26, 2018

Apologies for the lack of response, I'm still working on this. Hoping to push changes by tonight.

@kx-chen kx-chen force-pushed the deploy-to-netlify branch 6 times, most recently from 048b5ca to e1296fb Compare November 26, 2018 07:01
.travis.yml Outdated
@@ -17,6 +23,10 @@ jobs:
- <<: *xenial-mixin
python: 3.7

- stage: deploy
python: 3.6
script: "python -m statik.cmdline --upload=netlify --netlify-site-id=47df04ea-4f33-41a5-955e-3f48d6680b9d -p examples/blog"
Copy link
Collaborator

@jayvdb jayvdb Nov 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great at https://travis-ci.org/kx-chen/statik/jobs/459619320

python -m statik --... doesnt work? .cmdline is needed? that is a bug.

the hyperlinks in https://5bfb9b11792f895827ef832e--jolly-noyce-463b1a.netlify.com/ are not working.
can you double check that is a separate issue, and raise as a bug.

also use a travis environment variable instead of 47df04ea-4f33-41a5-955e-3f48d6680b9d , as the main repo will use a different site, and other forks will need to create their own also, and set a different value for their travis builds.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the hyperlinks in https://5bfb9b11792f895827ef832e--jolly-noyce-463b1a.netlify.com/ are not working.
can you double check that is a separate issue, and raise as a bug.

Links seem to work for me. Some links do go to nowhere, but it seems like it was intentional, from the templates. Should I still raise the bug report?

python -m statik --... doesnt work? .cmdline is needed? that is a bug.

python -m statik doesn't work locally for me. There isn't a __main__ entry point.

also use a travis environment variable instead of 47df04ea-4f33-41a5-955e-3f48d6680b9d , as the main repo will use a different site, and other forks will need to create their own also, and set a different value for their travis builds.

Done. https://travis-ci.org/kx-chen/statik/jobs/461611795

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it seems like it was intentional, from the templates. Should I still raise the bug report?

Yes

python -m statik doesn't work locally for me. There isn't a main entry point.

Another bug report.

Later today, I'll set up a netlify site and set NETLIFY_SITE_ID for merging.

Then we can look at your git+ requirement

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues made.

Add functionality to allow user to upload generate files to Netlify

Closes thanethomson#82
@jayvdb jayvdb merged commit 52e0da5 into thanethomson:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants