-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add upload to Netlify feature #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good
822066e
to
0953c84
Compare
Apologies for the lack of response, I'm still working on this. Hoping to push changes by tonight. |
048b5ca
to
e1296fb
Compare
.travis.yml
Outdated
@@ -17,6 +23,10 @@ jobs: | |||
- <<: *xenial-mixin | |||
python: 3.7 | |||
|
|||
- stage: deploy | |||
python: 3.6 | |||
script: "python -m statik.cmdline --upload=netlify --netlify-site-id=47df04ea-4f33-41a5-955e-3f48d6680b9d -p examples/blog" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great at https://travis-ci.org/kx-chen/statik/jobs/459619320
python -m statik --...
doesnt work? .cmdline
is needed? that is a bug.
the hyperlinks in https://5bfb9b11792f895827ef832e--jolly-noyce-463b1a.netlify.com/ are not working.
can you double check that is a separate issue, and raise as a bug.
also use a travis environment variable instead of 47df04ea-4f33-41a5-955e-3f48d6680b9d
, as the main repo will use a different site, and other forks will need to create their own also, and set a different value for their travis builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the hyperlinks in https://5bfb9b11792f895827ef832e--jolly-noyce-463b1a.netlify.com/ are not working.
can you double check that is a separate issue, and raise as a bug.
Links seem to work for me. Some links do go to nowhere, but it seems like it was intentional, from the templates. Should I still raise the bug report?
python -m statik --...
doesnt work? .cmdline is needed? that is a bug.
python -m statik
doesn't work locally for me. There isn't a __main__
entry point.
also use a travis environment variable instead of 47df04ea-4f33-41a5-955e-3f48d6680b9d , as the main repo will use a different site, and other forks will need to create their own also, and set a different value for their travis builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it seems like it was intentional, from the templates. Should I still raise the bug report?
Yes
python -m statik doesn't work locally for me. There isn't a main entry point.
Another bug report.
Later today, I'll set up a netlify site and set NETLIFY_SITE_ID for merging.
Then we can look at your git+ requirement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues made.
e1296fb
to
bb76af5
Compare
Add functionality to allow user to upload generate files to Netlify Closes thanethomson#82
bb76af5
to
52e0da5
Compare
Add functionality to allow user to upload generate files to Netlify
Closes #82