-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proposal to remove Gossip #484
Comments
Is there a planned replacement or will static addresses be the only option? |
All will be covered by proposal (: TL;DR: File SD is planned as a replacement. (Only on querier and ruler, as those only requires such logic) |
It would actually be nice to have support for DNS-based SD, so we could provide a single FQDN, e.g. |
Done. |
Doesn't seems to be a well thought decision to remove autodiscovery for tool that supposed to be used in dynamic environments like aws with instances going up and down for whatever reason. |
@drax68 did you have a chance to read the proposal? DNS discovery gives exactly the same dynamicity without massive overhead (and other disadvantage mentioned in document) of gossip protocol (: Let me know if any other functionality is missing. |
Proposal completed. |
Additionally fix https://github.com/improbable-eng/thanos/blob/master/docs/getting_started.md#communication-between-components ASAP to stop confusion around which component should talk with which component.
The text was updated successfully, but these errors were encountered: