Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

SourceMapping fix is needed #23

Closed
xasima opened this Issue · 4 comments

2 participants

@xasima

It seems that both comments for sourcemap are needed.
The first one is presented in generator-closure already, the second one needs to be added.

//@sourceMappingURL=app/jsc/sourcemap.js.map
//# sourceMappingURL=/jsc/sourcemap.js.map

The Chrome Canary doesn't perform the additional GET to sourcemap with appropriate option enabled without the latest comment.

@xasima

Put please your attention on the 1) absolute path and 2) the absence of app prefix

@thanpolas thanpolas closed this in ef030dd
@thanpolas
Owner

@xasima fixed all issues you raised, sourcemaps needed an updated indeed thanks!

The other errors resulted from the compilation by a custom Closure Compiler which was rigged so it would strip all logs off the build. I reverted back to the vanilla Closure Compiler, which will include all the logging facilities in the final build...

I should take the time to update the custom Closure Compiler build. Will not happen in the foreseeable future...

@xasima

Needs to reopen

You missed to specify the sourceMappingURL in the fix
//# sourceMappingURL=/jsc/sourcemap.js.map

@thanpolas
Owner

saw it and fixed on SHA: 7355ab4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.