Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceMapping fix is needed #23

Closed
xasima opened this issue Jan 10, 2014 · 4 comments
Closed

SourceMapping fix is needed #23

xasima opened this issue Jan 10, 2014 · 4 comments

Comments

@xasima
Copy link

xasima commented Jan 10, 2014

It seems that both comments for sourcemap are needed.
The first one is presented in generator-closure already, the second one needs to be added.

//@sourceMappingURL=app/jsc/sourcemap.js.map
//# sourceMappingURL=/jsc/sourcemap.js.map

The Chrome Canary doesn't perform the additional GET to sourcemap with appropriate option enabled without the latest comment.

@xasima
Copy link
Author

xasima commented Jan 10, 2014

Put please your attention on the 1) absolute path and 2) the absence of app prefix

@thanpolas
Copy link
Owner

@xasima fixed all issues you raised, sourcemaps needed an updated indeed thanks!

The other errors resulted from the compilation by a custom Closure Compiler which was rigged so it would strip all logs off the build. I reverted back to the vanilla Closure Compiler, which will include all the logging facilities in the final build...

I should take the time to update the custom Closure Compiler build. Will not happen in the foreseeable future...

@xasima
Copy link
Author

xasima commented Jan 10, 2014

Needs to reopen
You missed to specify the sourceMappingURL in the fix
//# sourceMappingURL=/jsc/sourcemap.js.map

@thanpolas
Copy link
Owner

saw it and fixed on SHA: 7355ab4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants