This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
fix account type method #1118
Merged
fix account type method #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypto-facs
requested review from
fedekunze,
khoslaventures and
jolube
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1118 +/- ##
=======================================
Coverage 61.86% 61.86%
=======================================
Files 88 88
Lines 7285 7285
=======================================
Hits 4507 4507
Misses 2557 2557
Partials 221 221
|
fedekunze
added a commit
that referenced
this pull request
Jun 8, 2022
* build(deps): bump github.com/stretchr/testify from 1.7.1 to 1.7.2 (#1115) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.1 to 1.7.2. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.7.1...v1.7.2) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * tests: update consensus params (#1117) * tests: update consensus params * fix * fix(types): account type method (#1118) * fix account type method * update changelog * update changelog * update changelog Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
devon-chain
pushed a commit
to PundiAI/ethermint
that referenced
this pull request
Jun 10, 2022
* fix account type method * update changelog
hoanguyenkh
pushed a commit
to AstraProtocol/ethermint
that referenced
this pull request
Jul 27, 2022
* build(deps): bump github.com/stretchr/testify from 1.7.1 to 1.7.2 (evmos#1115) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.1 to 1.7.2. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.7.1...v1.7.2) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * tests: update consensus params (evmos#1117) * tests: update consensus params * fix * fix(types): account type method (evmos#1118) * fix account type method * update changelog * update changelog * update changelog Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
Fix empty code hash comparison on account Type() method
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)