Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPRECATED Action signature #12

Open
hug33k opened this issue Jun 20, 2016 · 2 comments
Open

DEPRECATED Action signature #12

hug33k opened this issue Jun 20, 2016 · 2 comments
Assignees

Comments

@hug33k
Copy link

hug33k commented Jun 20, 2016

Hi,

Doesn't matter the action I choose, I've got this error message. It doesn't disturb the client, I can still do anything I want but I hope you could fix it, if ever cli changes something and makes your client no longer functional.

$>asana ts
 0 [ 2016-06-20 ] Task ...
DEPRECATED Action signature.  Must be `cli.ActionFunc`.  This is an error in the application.  Please contact the distributor of this application if this is not you.  See https://github.com/urfave/cli/blob/master/CHANGELOG.md#deprecated-cli-app-action-signature
@wakest
Copy link

wakest commented Aug 14, 2016

I have the same error

@thash thash self-assigned this Sep 18, 2016
@thash
Copy link
Owner

thash commented Sep 18, 2016

@hug33k, @wakest, thanks for reporting the issue. I understand it's caused by cli library update.

According to 2016-04-30 update, surely cli returns deprecation message.

Specifying an Action with the legacy return signature of func(*cli.Context) will produce a deprecation message to stderr

However currently latest cli library does not return "DEPRECATED" message you referred, because of the change following issue & commit.

urfave/cli#507
urfave/cli@8e6aa34

Anyway I need to follow the change, but I guess you could avoid the deprecated message by updating cli to the latest version. If I misunderstand something, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants