Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some enums ints #102

Closed
flibitijibibo opened this issue Jul 18, 2024 · 2 comments
Closed

Make some enums ints #102

flibitijibibo opened this issue Jul 18, 2024 · 2 comments
Assignees

Comments

@flibitijibibo
Copy link
Collaborator

I'm not super sure about IndexElementSize...

SDL_GpuIndexElementSize: Should we just make this an int?

Definitely want to do this for sample count:

SDL_GpuSampleCount: same (but I don't feel strongly about either of these, I know that the lower level tends to use enums for these anyhow)

@flibitijibibo
Copy link
Collaborator Author

Wanted to do this one today but it's a bit too invasive... I'm going to make the call now that IndexElementSize is staying since raw ints are an invitation to do the math wrong (i.e. "did they mean bits or bytes?"), sample count I could go either way - @thatcosmonaut, @TheSpydog, will leave this up to you depending on what each backend prefers.

@flibitijibibo
Copy link
Collaborator Author

Looking through the API support coverage, the enum values for sample count are probably the way to go - we could maybe add 16X but it's not a dealbreaker.

@flibitijibibo flibitijibibo closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants