Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button with Outline variant should respect the ButtonColor prop #173

Closed
tqwewe opened this issue Apr 21, 2024 · 2 comments
Closed

Button with Outline variant should respect the ButtonColor prop #173

tqwewe opened this issue Apr 21, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@tqwewe
Copy link
Contributor

tqwewe commented Apr 21, 2024

The ButtonColor prop doesn't seem to work when using other variants such as Outline.

In the case of outline, the text color should perhaps be influenced by the button color prop. So <Button variant=ButtonVariant::Outline color=ButtonColor::Primary>"Hello"</Button> should have a blue text for the button.

A good example of this would be the official Thaw UI website's navigation not indicating the current page.

Screenshot 2024-04-21 at 11 39 51 PM

In the screenshot above, I'm on the Thaw UI "Guide" page, however the button does not indicate this. It would make sense for this to be blue as suggested in this issue.

@luoxiaozero
Copy link
Collaborator

https://www.naiveui.com/en-US/os-theme/components/button#secondary.vue
https://www.naiveui.com/en-US/os-theme/components/button#quaternary.vue
Like this?

I feel that this will be a breakthrough change and we can implement it in 0.4. It won't be long, as lepots0.7-alpha should be released soon.

@luoxiaozero luoxiaozero added the enhancement New feature or request label Apr 22, 2024
@luoxiaozero luoxiaozero added this to the 0.4 milestone Apr 22, 2024
@luoxiaozero
Copy link
Collaborator

Given that the v0.4 release already follows the Fluent design specification, I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants