Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.7+ compatibility (keyword arguments) #85

Closed
thbar opened this issue Feb 4, 2020 · 4 comments
Closed

Ruby 2.7+ compatibility (keyword arguments) #85

thbar opened this issue Feb 4, 2020 · 4 comments

Comments

@thbar
Copy link
Owner

thbar commented Feb 4, 2020

Due to the recent changes announced here:

https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/

(and tracked here initially https://bugs.ruby-lang.org/issues/14183)

it is possible to get warnings (and later with Ruby 2.8+, most likely errors), depending on how the components are implemented (and this is the case with kiba-common, for instance).

I'm opening this issue to track this down.

For now I would recommend to stick with Ruby 2.6 if possible.

thbar added a commit that referenced this issue Feb 4, 2020
This adds support for all component types.
@thbar
Copy link
Owner Author

thbar commented Feb 4, 2020

I've started working on proper support on branch ruby-3-compat-keyword-arguments. WIP and will require large testing.

@thbar thbar changed the title Investigate warnings with Ruby 2.7+ Ruby 2.7+ compatibility (keyword arguments) Feb 5, 2020
@thbar
Copy link
Owner Author

thbar commented Feb 5, 2020

kiba-common preview compatibility branch is also available at thbar/kiba-common#27. This will need real life testing.

thbar added a commit that referenced this issue Sep 14, 2020
This adds support for all component types.
@thbar
Copy link
Owner Author

thbar commented Sep 14, 2020

Ruby 2.7 compatibility is available in master.

A new release will be published later with corresponding changes.

@thbar
Copy link
Owner Author

thbar commented Sep 24, 2020

Release v3.5.0 has been published. Closing!

@thbar thbar closed this as completed Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant