Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jester #305

Merged
merged 3 commits into from
Jul 25, 2018
Merged

Fix jester #305

merged 3 commits into from
Jul 25, 2018

Conversation

waghanza
Copy link
Collaborator

Hi,

This PR fix jester implementation

@see https://github.com/TechEmpower/FrameworkBenchmarks/tree/master/frameworks/Nim/jester

@dom96 Could you validate this code ?

Regards,

@dom96
Copy link
Contributor

dom96 commented Jul 25, 2018

You need that .nimble file. You can't remove it.

@waghanza
Copy link
Collaborator Author

@dom96 Even if option are passed through the compiler ?

@waghanza waghanza changed the title Fix jest Fix jester Jul 25, 2018
@dom96
Copy link
Contributor

dom96 commented Jul 25, 2018

You're calling nimble in the docker file and the .nimble file specifies dependencies for the script, so yes, you need the .nimble file.

Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@waghanza waghanza merged commit 3680931 into the-benchmarker:master Jul 25, 2018
@waghanza waghanza deleted the fix_jester branch July 25, 2018 16:51
waghanza added a commit that referenced this pull request Jul 30, 2018
* add Java/act framework

* validate working for each framework on travis

* remove unused files

* Add restify (node) (#276)

* add restify (node)

* add restify to node targets on makefile

* add dockerfile for restify (node)

* Introducing Vibora (#285)

* add vibora

this code has been tested and it requires `SO_REUSEPORT` on Ubuntu 16.04, therefore can't guarantee anything about the code. Use it at your own risk.

* Update benchmarker.cr

* update for vibora

* fix routing -> type not required

* add vibora

* use gunicorn for sanic

* use http://meinheld.org/ to enable async networking with django

* reuse port on tornado

* use meinheld / SO_REUSEPORT on django

* use meinheld / SO_REUSEPORT on flask

* Introducing Vibora (#285)

* add vibora

this code has been tested and it requires `SO_REUSEPORT` on Ubuntu 16.04, therefore can't guarantee anything about the code. Use it at your own risk.

* Update benchmarker.cr

* update for vibora

* fix routing -> type not required

* add vibora

* use gunicorn for sanic

* use http://meinheld.org/ to enable async networking with django

* reuse port on tornado

* use meinheld / SO_REUSEPORT on django

* use meinheld / SO_REUSEPORT on flask

* update nim/mofuw (#268)

* update nim/mofuw

* fixed nest.nim not found

* cleanup ranking, display only two tables

* format percentile

* rank by 99th percentile, for latency

* update mofuw (#294)

* fix jester (#297)

* fix jester

* dockerfile refactor (jester)

* update tornado to 5.1.0 (#298)

* use a redis to store results

* fix server_nim_mofuw (#301)

* add redis on ci (storage will change)

* create a sample resultset

* add more details on results tables

* Fix jester (#305)

* fix jester, seeing tfb implementation

* restore nimble file

* fix version

* use an internal in-memory storage for results

* Restore hapijs (#306)

* restore hapijs

* add hapi to make targets

* clarified tiles

* compute results from each endpoints (previously was only on GET:/)

* restore 50th percentile ranking for latency

* Optimize mofuw implementation (#304)

* remove unused files (mofuw)

* homogenize implementation (inspiring from techempower)

* add results sets for each route

* remove duplicate target in makefile

* fix python version for vibora
waghanza added a commit that referenced this pull request Jul 30, 2018
* add Java/act framework

* validate working for each framework on travis

* remove unused files

* Add restify (node) (#276)

* add restify (node)

* add restify to node targets on makefile

* add dockerfile for restify (node)

* Introducing Vibora (#285)

* add vibora

this code has been tested and it requires `SO_REUSEPORT` on Ubuntu 16.04, therefore can't guarantee anything about the code. Use it at your own risk.

* Update benchmarker.cr

* update for vibora

* fix routing -> type not required

* add vibora

* use gunicorn for sanic

* use http://meinheld.org/ to enable async networking with django

* reuse port on tornado

* use meinheld / SO_REUSEPORT on django

* use meinheld / SO_REUSEPORT on flask

* Introducing Vibora (#285)

* add vibora

this code has been tested and it requires `SO_REUSEPORT` on Ubuntu 16.04, therefore can't guarantee anything about the code. Use it at your own risk.

* Update benchmarker.cr

* update for vibora

* fix routing -> type not required

* add vibora

* use gunicorn for sanic

* use http://meinheld.org/ to enable async networking with django

* reuse port on tornado

* use meinheld / SO_REUSEPORT on django

* use meinheld / SO_REUSEPORT on flask

* update nim/mofuw (#268)

* update nim/mofuw

* fixed nest.nim not found

* cleanup ranking, display only two tables

* format percentile

* rank by 99th percentile, for latency

* update mofuw (#294)

* fix jester (#297)

* fix jester

* dockerfile refactor (jester)

* update tornado to 5.1.0 (#298)

* use a redis to store results

* fix server_nim_mofuw (#301)

* add redis on ci (storage will change)

* create a sample resultset

* add more details on results tables

* Fix jester (#305)

* fix jester, seeing tfb implementation

* restore nimble file

* fix version

* use an internal in-memory storage for results

* Restore hapijs (#306)

* restore hapijs

* add hapi to make targets

* clarified tiles

* compute results from each endpoints (previously was only on GET:/)

* restore 50th percentile ranking for latency

* Optimize mofuw implementation (#304)

* remove unused files (mofuw)

* homogenize implementation (inspiring from techempower)

* add results sets for each route

* remove duplicate target in makefile

* fix python version for vibora
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants