Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choice name duplicated in path #22

Closed
cbchouinard opened this issue Mar 2, 2015 · 1 comment
Closed

Choice name duplicated in path #22

cbchouinard opened this issue Mar 2, 2015 · 1 comment

Comments

@cbchouinard
Copy link
Contributor

In the following spec the name of the .all promise name is duplicated in the path:

it 'should generate good path', (done) ->
      treeComposition = (c, d) ->
        sub = c.continue 'subtree_c'
        sub.deliver d
        sub.then 'subthen0', (c, d) ->
          d
        .then 'subthen1', (c, d) ->
          d
      t = Root()
      t.deliver 10
      .then 'then0', (c, d) ->
        d
      .all 'allin', [
        treeComposition.bind @
        treeComposition.bind @
      ]
      .then 'then1', (c, d) ->
        d
      .finally (c, d) ->
        exp = {
          path: [
             'then0',
             'allin',
             'subtree_c',
             'subthen0',
             'subthen1',
             'then1']
          children: []
        }
        chai.expect(c.toSong()).to.eql exp
        done()
cbchouinard pushed a commit that referenced this issue Mar 2, 2015
cbchouinard pushed a commit that referenced this issue Mar 4, 2015
@bergie
Copy link
Contributor

bergie commented Mar 4, 2015

Fixed in 7fd19a0

@bergie bergie closed this as completed Mar 4, 2015
cbchouinard pushed a commit that referenced this issue May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants