Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree abortion problem with sub branching #35

Closed
cbchouinard opened this issue Mar 16, 2015 · 2 comments
Closed

Tree abortion problem with sub branching #35

cbchouinard opened this issue Mar 16, 2015 · 2 comments

Comments

@cbchouinard
Copy link
Contributor

When sub-branching, if somewhere in promise chain we do a choice.abort() then the whole contest seems to "fullfills" without any winner (in fact the solver callback of the contest is not even called).
cbchouinard pushed a commit that referenced this issue Mar 16, 2015
spec for issue: #35
fbccb56
@bergie
Copy link
Contributor

bergie commented Mar 16, 2015

@cbchouinard thanks! I think this is actually what makes the two previous failing tests from @d4tocchini also break.

https://magnum.travis-ci.com/the-grid/Flowerflip/builds/10241689#L479

@bergie
Copy link
Contributor

bergie commented Mar 16, 2015

@cbchouinard @d4tocchini however, the spec provided does appear to pass in master:

screenshot 2015-03-16 at 16 05 16

cbchouinard pushed a commit that referenced this issue Mar 16, 2015
Real failing test this time :) for issue #35
b87f8e4
@bergie bergie closed this as completed Mar 20, 2015
cbchouinard pushed a commit that referenced this issue May 18, 2015
spec for issue: #35
4e371c5
cbchouinard pushed a commit that referenced this issue May 18, 2015
Real failing test this time :) for issue #35
64a461c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bergie @cbchouinard