Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolate environment variables in config file #158

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Conversation

dotansimha
Copy link
Member

Closes #149

Copy link

github-actions bot commented Nov 26, 2023

💻 Website Preview

The latest changes are available as preview in: https://a0146c2c.conductor-t2.pages.dev

Copy link

github-actions bot commented Nov 26, 2023

✅ Benchmark Results

     data_received..................: 212 MB  2.7 MB/s
     data_sent......................: 658 MB  8.2 MB/s
     http_req_blocked...............: avg=2.67µs  min=621ns    med=1.44µs  max=29.98ms p(90)=1.96µs  p(95)=2.19µs 
     http_req_connecting............: avg=530ns   min=0s       med=0s      max=29.93ms p(90)=0s      p(95)=0s     
   ✓ http_req_duration..............: avg=4.26ms  min=61.7µs   med=2.26ms  max=92.32ms p(90)=11.06ms p(95)=15.37ms
       { expected_response:true }...: avg=4.26ms  min=61.7µs   med=2.26ms  max=92.32ms p(90)=11.06ms p(95)=15.37ms
   ✓ http_req_failed................: 0.00%   ✓ 0            ✗ 1669574
     http_req_receiving.............: avg=40.56µs min=6.09µs   med=15.97µs max=55.34ms p(90)=22.78µs p(95)=75.09µs
     http_req_sending...............: avg=15.7µs  min=3.59µs   med=7.84µs  max=35.34ms p(90)=10.9µs  p(95)=14.95µs
     http_req_tls_handshaking.......: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=4.2ms   min=41.35µs  med=2.22ms  max=74.37ms p(90)=10.96ms p(95)=15.25ms
     http_reqs......................: 1669574 20869.578789/s
     iteration_duration.............: avg=4.37ms  min=107.18µs med=2.35ms  max=92.76ms p(90)=11.23ms p(95)=15.57ms
     iterations.....................: 1669574 20869.578789/s
     vus............................: 1       min=1          max=199  
     vus_max........................: 200     min=200        max=200  

Copy link

github-actions bot commented Nov 26, 2023

🐋 This PR was built and pushed to the following Docker images:

Docker Bake metadata
{
"conductor": {
  "containerimage.config.digest": "sha256:55a01acf2acf8984f6df17c95c8050247be71cea50a8ce3af5c672d14dd9b6c8",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
    "digest": "sha256:d5f03893457dd2b96debf7674320e82a133add991e81ffac8dd53ac90720bda5",
    "size": 901,
    "platform": {
      "architecture": "amd64",
      "os": "linux"
    }
  },
  "containerimage.digest": "sha256:d5f03893457dd2b96debf7674320e82a133add991e81ffac8dd53ac90720bda5",
  "image.name": "ghcr.io/the-guild-org/conductor-t2/conductor:021090b976fbff2e44779e29ae68117fb64b8dc7"
}
}

Copy link
Member

@YassinEldeeb YassinEldeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and rebase with #164

@dotansimha dotansimha merged commit 7435f48 into master Nov 27, 2023
13 checks passed
@dotansimha dotansimha deleted the interpolate-vars branch November 27, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interpolate environment variables in configuration
2 participants