-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved env var interpolation #164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💻 Website PreviewThe latest changes are available as preview in: https://d2154a0a.conductor-t2.pages.dev |
✅ Benchmark Results
|
🐋 This PR was built and pushed to the following Docker images: Docker Bake metadata{
"conductor": {
"containerimage.config.digest": "sha256:b5ded1596a2fd672635efe6ee31670a5feff7e6cbcb89288ef66d507f977fbcb",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"digest": "sha256:1deae3968a8767dbc53d26007016f0f713ab612e5c60ba69c3e8f4e8417632dc",
"size": 901,
"platform": {
"architecture": "amd64",
"os": "linux"
}
},
"containerimage.digest": "sha256:1deae3968a8767dbc53d26007016f0f713ab612e5c60ba69c3e8f4e8417632dc",
"image.name": "ghcr.io/the-guild-org/conductor-t2/conductor:b06169dcfdb7dc3a17844a91eda94e1b6031a1f3"
}
} |
dotansimha
approved these changes
Nov 27, 2023
dotansimha
pushed a commit
that referenced
this pull request
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interpolation Progress
EnvVarsFetcher
abstraction, in favor of closures as a second argument toload_config
.lazy_static
dependency, since we don't really need it, we copy over the variables anyways.Better Interpolation Logging
info
as the default level, then modify the log-level afterwardsprintln!(...)
before logger subscriber initialization including the config parser's code into usinginfo!
,error!
andwarning!