A lot of fixes #36
Merged
A lot of fixes #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kamilkisiela
commented
Jan 4, 2024
kamilkisiela
commented
- Visit every field in provides and requires directives
- Fix unnecessary join__field(override:) on Query fields when it points to non-existing subgraph
- Deduplicate composed directives
- Remove duplicated link spec definitions
- Drop unused fields marked with @external only in a single type in Fed v1
kamilkisiela
force-pushed
the
kamil-improvements
branch
from
c814a1f
to
455c14d
Compare
Merged
n1ru4l
pushed a commit
that referenced
this pull request
Jan 22, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @theguild/federation-composition@0.7.1 ### Patch Changes - [#36](#36) [`fdba937`](fdba937) Thanks [@kamilkisiela](https://github.com/kamilkisiela)! - Visit every field in provides and requires directives - [#36](#36) [`fdba937`](fdba937) Thanks [@kamilkisiela](https://github.com/kamilkisiela)! - Fix unnecessary join\_\_field(override:) on Query fields when it points to non-existing subgraph - [#36](#36) [`fdba937`](fdba937) Thanks [@kamilkisiela](https://github.com/kamilkisiela)! - Deduplicate composed directives - [#39](#39) [`e77eb2c`](e77eb2c) Thanks [@n1ru4l](https://github.com/n1ru4l)! - Ignore inaccessible field arguments within the `DEFAULT_VALUE_USES_INACCESSIBLE` rule. Fixes an issue where an inaccessible field argument uses a default value that is inaccessible would cause a false error. ```graphql type User @key(fields: "id") { id: ID friends(type: FriendType = FAMILY @inaccessible): [User!]! } enum FriendType { FAMILY @inaccessible FRIEND } ``` - [#36](#36) [`fdba937`](fdba937) Thanks [@kamilkisiela](https://github.com/kamilkisiela)! - Remove duplicated link spec definitions - [#36](#36) [`fdba937`](fdba937) Thanks [@kamilkisiela](https://github.com/kamilkisiela)! - Drop unused fields marked with @external only in a single type in Fed v1 - [`220dfc0`](220dfc0) Thanks [@kamilkisiela](https://github.com/kamilkisiela)! - Fix missing usedOverridden on non-external key field Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.