Create ESlint typescript config file for rules like @typescript-eslin…

…t/prefer-optional-chain (#422)
the-guild-org · Apr 21, 2024 · 2f6f4f0 · 2f6f4f0
1 parent 1cba729
commit 2f6f4f0
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/.changeset/strange-ravens-matter.md b/.changeset/strange-ravens-matter.md
@@ -0,0 +1,5 @@
+---
+"@theguild/eslint-config": patch
+---
+
+Fix @typescript-eslint/prefer-optional-chain causing eslint to fail if .js files are not included in tsconfig
diff --git a/packages/eslint-config/src/base.js b/packages/eslint-config/src/base.js
@@ -95,7 +95,6 @@ module.exports = {
 
     'prefer-object-has-own': 'error',
     'logical-assignment-operators': ['error', 'always', { enforceForIfStatements: true }],
-    '@typescript-eslint/prefer-optional-chain': 'error',
 
     yoda: 'error',
     'unicorn/prefer-export-from': ['error', { ignoreUsedVariables: true }],

diff --git a/packages/eslint-config/src/index.js b/packages/eslint-config/src/index.js
@@ -15,9 +15,7 @@ module.exports = {
     },
     {
       files: TS_FILE,
-      rules: {
-        '@typescript-eslint/consistent-type-assertions': 'error',
-      },
+      extends: './typescript',
     },
     {
       files: ['*.c{j,t}s'],

diff --git a/packages/eslint-config/src/typescript.js b/packages/eslint-config/src/typescript.js
@@ -0,0 +1,7 @@
+/** @type {import('eslint').Linter.Config} */
+module.exports = {
+  rules: {
+    '@typescript-eslint/consistent-type-assertions': 'error',
+    '@typescript-eslint/prefer-optional-chain': 'error',
+  },
+};