Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ESlint typescript config file for rules like @typescript-eslint/prefer-optional-chain #422

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

eddeee888
Copy link
Contributor

Some rules such as @typescript-eslint/prefer-optional-chain need tsconfig to work correctly. If applied on all files (e.g. .js), ESLint will not work, saying said files are not included in tsconfig.

This PR moves some typescript rules to a dedicated TS rule file.

…t/prefer-optional-chain

Some rules such as @typescript-eslint/prefer-optional-chain need tsconfig to work correctly.
If applied on all files (e.g. .js), ESLint will not work, saying said files are not included in tsconfig.
Copy link

changeset-bot bot commented Apr 21, 2024

🦋 Changeset detected

Latest commit: 701cf04

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@theguild/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dotansimha dotansimha merged commit 2f6f4f0 into the-guild-org:main Apr 21, 2024
3 checks passed
@eddeee888 eddeee888 deleted the fix-ts-eslint-config branch April 21, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants