Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app to load v3 definitions from new URL #14

Closed
mattsacks opened this issue Feb 3, 2022 · 2 comments
Closed

Update app to load v3 definitions from new URL #14

mattsacks opened this issue Feb 3, 2022 · 2 comments

Comments

@mattsacks
Copy link
Contributor

mattsacks commented Feb 3, 2022

Builds upon #13

@mattsacks
Copy link
Contributor Author

I think this is already taken care of:

So going backwards from when we load the JSON, here you can see us getting a version of it:

const url = `/definitions/${version}/${vpid}.json`;

That vid is the requiredDefinitionVersion that is stored for the device:

getMissingDefinition(device, requiredDefinitionVersion),

Which is loaded into the redux store based on it's protocol:

requiredDefinitionVersion: protocol >= 10 ? 'v3' : 'v2',

@olivia @ValdisThomann let me know that's wrong!

@ValdisThomann
Copy link
Contributor

We need to test this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants