Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Hex color input next to picker #90

Open
karlshea opened this issue Dec 27, 2022 · 1 comment · May be fixed by #264
Open

Feature request: Hex color input next to picker #90

karlshea opened this issue Dec 27, 2022 · 1 comment · May be fixed by #264

Comments

@karlshea
Copy link

Every time I flash my firmware I lose all of my lighting settings. This isn't a huge issue except for the color pickers: it's extremely difficult to figure out what the RGB value is currently set to (although a bit easier if running in a browser because I can inspect the color tile), and even harder to set it back to what it was.

If there was a text input that showed the current RGB hex values that would make it super simple to back up and restore those colors with just some copy & pasting.

Thanks!

@iMobs
Copy link

iMobs commented Apr 27, 2023

I'm taking a look at the ColorPicker component and wondering why not just use the native <input type="color" /> which would greatly simplify things and allow for setting the RGB, HSL, or hex values. Right now there's a whole lot of unnecessary math around mouse position within a div to determine the hue and saturation. There are also a ton of helpers for converting HSV colors to RGB and back that I suggest be replaced with a library like colord.

Another alternative is react-color for some predefined looks.

@xPaw xPaw linked a pull request Aug 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants