Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Extra Space over Title after closing a BottomSheet #28

Closed
troy-ob opened this issue May 23, 2023 · 8 comments
Closed

Android: Extra Space over Title after closing a BottomSheet #28

troy-ob opened this issue May 23, 2023 · 8 comments

Comments

@troy-ob
Copy link

troy-ob commented May 23, 2023

An extra white space is added over the title after closing a BottomSheet, see below:

image

The space disappears if the bottom sheet is reopened, but appears again after closing.

Steps to reproduce:

  1. Create new Maui project
  2. Install the the:49:BottomSheet NuGet package - version rc1, and follow the Readme for usage
  3. Copied the SimplePage from the Sample. Display the SimplePage-BottomSheet on ButtonClick
  4. Build and deploy on Android -> click button

This does not happen with the alpha7 version

@paulvarache
Copy link
Contributor

Could you confirm that you have configure the android project to use the Material3 style?

@troy-ob
Copy link
Author

troy-ob commented May 23, 2023

Thanks for the quick reply.

I created Platforms/Android/Resources/values/styles.xml and added to it:

<resources>
	<style name="Maui.MainTheme" parent="Theme.Material3.DayNight"></style>
</resources>

Are there any others steps to take that Android uses this theme?

@Jota-Devs
Copy link

Having the same problem here. Any news?

@paulvarache
Copy link
Contributor

Hi,

It took some time to figure out what was happening but this is finally fixed in version 1.0.0-rc2 available now

@gaterin
Copy link

gaterin commented May 31, 2023

I updated to 1.0.0-rc2 but i still have this issue

@troy-ob
Copy link
Author

troy-ob commented May 31, 2023

The update fixed it for me. But I had to add some more bottom-padding to the BottomSheet itself, as the content was cut off by a bit. Couldn't test it on iOS yet

@paulvarache paulvarache reopened this May 31, 2023
@paulvarache
Copy link
Contributor

Hi,

Thanks for reporting this. Can you please both add more information?

  • Are you using Shell or NavigationPage?
  • Which version of Android
  • Which device model

@gaterin
Copy link

gaterin commented May 31, 2023

I am using Shell, android version on emulator 11. using a pixel 5 device on emulator. i just tested it on my physical device and this issue seems to be fixed. i will be updating my emulator to a newer version thanks

@troy-ob troy-ob closed this as completed Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants