Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Clone for Data/Record #1

Closed
mcdenhoed opened this issue Feb 7, 2020 · 3 comments
Closed

Implement Clone for Data/Record #1

mcdenhoed opened this issue Feb 7, 2020 · 3 comments

Comments

@mcdenhoed
Copy link

Hello! This is a great library! Thanks for publishing!

Would you consider implementing Clone for Data/Record? I tried using this library to perform some edits on some SRECs and kept running into situations where I wanted to be a be able to just clone a Record object. Since all the Address structs and Vec implement Clone it shouldn't be too bad to add.
@the6p4c
Copy link
Owner

the6p4c commented Feb 8, 2020

Hi! I can't see how adding Clone would be a breaking change, so I'll try and get this done and bump the minor version as soon as I can.

@the6p4c
Copy link
Owner

the6p4c commented Feb 8, 2020

Added in a819084, published as v0.1.2 :)

@the6p4c the6p4c closed this as completed Feb 8, 2020
@mcdenhoed
Copy link
Author

That is awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcdenhoed @the6p4c