Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grade filter does not consider local grade context #119

Open
2 tasks
killakalle opened this issue May 4, 2021 · 7 comments
Open
2 tasks

Grade filter does not consider local grade context #119

killakalle opened this issue May 4, 2021 · 7 comments
Labels
Area: Grades Type: Bug Obvious malfunction that requires fixing

Comments

@killakalle
Copy link

What happened?

  1. Go to a boulder area
  2. Go to Search
  3. Go to Route list
  4. Start filtering by grade

The grades of the result list do not match the filter.

Apparently the Slides goes by FB (sport climbing) whereas the routes are shown and filtered by FB (bouldering). The difference is more subtle in Europe. However, when you go to other places in the world with different grade context, it becomes more obvious

Example url(s) to reproduce the problem:

Ideally also provide screenshots:

In Europe it's confusing because both grade context look the same
image

In Australia the difference is obvious
image

What you expected:

  • Grade filter follows local grade context
  • Grade filter understands when to filter boulder problems vs sport routes
@rouletout
Copy link

Fixed, closing

@killakalle
Copy link
Author

@rouletout
This is not fixed. The behavior looks still the same. Please, re-open this issue.

@rouletout rouletout added Area: Grades Type: Bug Obvious malfunction that requires fixing labels Oct 16, 2021
@rouletout rouletout reopened this Oct 16, 2021
@bkucsera
Copy link

For the grade problem we can have a comprehensive solution with the upcoming Profile features, however new questions arise.
In this new Profile system, the users will be able to set their default grade system. Once they set, every grade will appear in that grade system in the app.
Further questions with this solution:

  • what happens if a node (area, crag, etc) contains boulder and sport routes? Can it happen or these are always showed in a different list?
  • We should bring back the the tags to the grade, to make it clear for the users, if they see a font_french or lead_french grade. What do you think about this?

@scd
Copy link

scd commented Oct 19, 2021 via email

@bkucsera
Copy link

The goal is to have the best user experience. I think one part of users want to see the grades in the original/local grade context, other group of users want to see in their preferred grading system. For example, if a european climber goes bouldering to the USA, maybe wants to search for boulders around 7a, not V6.

So, other solution can be to add a grade type changing possibility to the Search tab.

What if we put a switch button on the Route search tab? The user will see the search list in the local grade context, but can switch to the preferred grading system (what is set in the user's Profile).

What do you think about this solution? @killakalle @rouletout

@rouletout
Copy link

Sounds good - this is what we have on the web with the "Convert" button.

@rouletout
Copy link

+1 from support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Grades Type: Bug Obvious malfunction that requires fixing
Projects
None yet
Development

No branches or pull requests

4 participants