Update baseof template #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This covers #238 |
enguerran
commented
Oct 2, 2020
There was a problem hiding this comment.
I added a commit to add variable scoping within the head_additions.html partial.
See https://gohugo.io/templates/partials/#variable-scoping
Remicck
pushed a commit
to Remicck/gohugo-theme-ananke
that referenced
this pull request
Mar 7, 2022
* Update comments about internal templates * Add missing meta description for SEO * Add variable scoping to partial See https://gohugo.io/templates/partials/#variable-scoping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use this template and I realized via Google Lighthouse that the
<meta name="description" content="">tag was missing. Also, I updated the link to the internal templates doc.
Let me know if the PR needs more work.